Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In order to make changes to the module, as a developer, I want automated regression tests, so that I can be confident that my changes have not broken the module.
Proposed resolution
Add tests.
Remaining tasks
Write patchReview and feedbackRTBC and feedbackMergeEnable automated testing in project settings
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
To be determined.
Comment | File | Size | Author |
---|---|---|---|
#5 | 3161264-5--add-tests.patch | 11.61 KB | jcnventura |
Comments
Comment #2
mparker17Here's a preliminary patch to add tests.
I have an issue with my local setup, and I'd like to rebuild my local environment to fix it, but I'm uploading this patch to take a snapshot of my work thus far. It is entirely possible this patch will fail spectacularly.
Essentially, I'm following the direction that Views' own \Drupal\Tests\views\Functional\Plugin\StyleTableTest and \Drupal\Tests\views\Functional\Plugin\StyleOpmlTest tests take for testing built-in Views Style plugins, which is to define a custom view in a hidden testing module, and run Functional tests on that view.
Comment #3
mparker17Okay, this should work now!
Comment #4
mparker17Fixed a poorly-worded comment and added a test to make sure the JavaScript library is correctly output on pages where the jump menu is used.
Comment #5
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedTesting modules do not need the core_version_requirement line. And the new test module should be in the tests directory.
Comment #7
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedNow to enable these tests.
Comment #8
mparker17Awesome, thanks!