Steps to reproduce

1) Upgrade Module page version 8.x-2.9 to the latest version.
2) Run drush updb for database updates.
3) We get the following error -

issue

Expected result - Database update should be smooth even if the module upgrade is from 8.x-2.9 to any version >= 8.x-2.13

Root cause -

On `drush updb` the below code for entity load is expecting `modal_page_modal__roles` table.
$modals = \Drupal::entityTypeManager()->getStorage('modal_page_modal')->loadMultiple();
https://git.drupalcode.org/project/modal_page/-/blob/8.x-2.13/src/Entity...

Proposed resolution -
Instead of setting the field value the entity way we can update the `auto_open` and `enable_dont_show_again_option` field using database api.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wil2091 created an issue. See original summary.

wil2091’s picture

wil2091’s picture

Assigned: wil2091 » Unassigned
renatog’s picture

Status: Active » Needs review
Issue tags: +Needs manual testing

Woow good catch! Really Looks good!

I'll test it

dvym’s picture

Great Work!!

paulocs’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
12.96 KB

After applied patch #2, the update is running cleanly.

renatog’s picture

Issue tags: -Needs manual testing

Tested and really works well also for me

  • RenatoG committed 4743e2e on 8.x-2.x authored by wil2091
    Issue #3162395 by wil2091, paulocs, RenatoG, dvym: Module upgrade from 8...
renatog’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to the dev branch.

Thanks for your review Paulo and thank you so much for your solution @wil2091

Your contributions are amazing!

I'll generate a new release for this

renatog’s picture

Status: Fixed » Closed (fixed)