Problem/Motivation

FYI, the dictionary contains 'skłodowska' which is a family name, see Marie Curie.

@quietone commented here

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3164652-6.patch763 bytesjungle
#3 3164652-3.patch1.49 KBjungle
#2 3164652-2.patch1.43 KBjungle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer and at InterGreat Education Group commented
Status: Active » Needs review
FileSize
3164652-2.patch1.43 KB

Changes made to the comment in Substr.php and the dictionary file. So it's unnecessary to trigger the CI.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer and at InterGreat Education Group commented
FileSize
3164652-3.patch1.49 KB 
+++ b/core/modules/migrate/src/Plugin/migrate/process/Substr.php
@@ -32,14 +32,14 @@
- * If some_text_field was 'Marie Skłodowska Curie' then
- * $destination['new_text_field'] would be 'Skłodowska'.
+ * If some_text_field was 'Dries Buytaert' then $destination['new_text_field']
+ * would be 'Buytaert'.

Instead of using Dries Buytaert, probably, using 'Foo bar baz' here is better. Attaching a new patch using 'Foo bar baz', no interdiff on purpose.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Reviewed & tested by the community » Needs work

The example code can be changed without removing the reference to Marie Curie, which I would prefer to keep. Or is there a policy about the use of names?

 * @code
 * process:
 *   new_text_field:
 *     plugin: substr
 *     source: some_text_field
 *     start: 6
 *     length: 5
 * @endcode
 * If some_text_field was 'Marie Curie' then
 * $destination['new_text_field'] would be 'Curie'.
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer and at InterGreat Education Group commented
Status: Needs work » Needs review
FileSize
3164652-6.patch763 bytes

@quietone, If you prefer keeping the reference, then I'd ignore it simply by using // cspell:ignore skłodowska

Marie Curie is a GREAT woman, but there are a lot of great people in the world, frankly speaking, I don't know her real name, till checked it today, But I knew her name in Chinese when I was young, it's written in our textbook(s). Personally, I prefer using foo bar baz ... or Lorem Ipsum for such examples in the IT world still.

Or is there a policy about the use of names?

No, as I know.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented

Personally, I prefer using foo bar baz ... or Lorem Ipsum for such examples in the IT world still.

That is probably the best course of action here. And it avoids setting a precedence of allowing names that are not in the dictionary. That means that patch #3 is acceptable.

Thanks for listening to me.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer and at InterGreat Education Group commented
Status: Needs review » Reviewed & tested by the community

Thanks @quietone.

Even though I think #3 is better as an example in documentation, but I do respect contributor's personal preference on adding/added some meaningful/preferred words to the codebase in some way, such as beloved people names/favorite movie names etc. So #6 is RTBC to me as well.

BTW #2845490: Add documentation to Substr process plugin or commit 6ebf68a217a8954d40f8455b9747d3ee2f1eaf02 added/introduced Skłodowska by @quietone.

Setting back to RTBC.

  • catch committed 041cf28 on 9.1.x 
    Issue #3164652 by jungle, quietone, longwave: Update modules/migrate/src...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

We have a lot more trivial references in tests than Marie Curie, some are great, some not so much, but I don't think cspell should decide how we approach that.

Committed 041cf28 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.