CommentFileSizeAuthor
#5 3164708-5.patch5.24 KBliuchanggang
#2 Screen Shot 2020-08-11 at 8.31.47 PM.png231.03 KBliuchanggang
#2 3164708-2.patch5.24 KBliuchanggang
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

liuchanggang created an issue. See original summary.

liuchanggang’s picture

liuchanggang CreditAttribution: liuchanggang commented
Issue summary: View changes
FileSize
3164708-2.patch5.24 KB
Screen Shot 2020-08-11 at 8.31.47 PM.png231.03 KB

This change is ready for review.Screeshot

liuchanggang’s picture

liuchanggang CreditAttribution: liuchanggang commented
Issue summary: View changes
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Issue summary: View changes
Status: Needs review » Needs work

@liuchanggang

Thank you for adding the Refresh button.

+++ b/modules/cloud_service_providers/terraform/src/Controller/ApiController.php
@@ -254,6 +258,47 @@ class ApiController extends ControllerBase implements ApiControllerInterface {
+      if ($updated !== FALSE) {

Let's change to $updated === TRUE:

liuchanggang’s picture

liuchanggang CreditAttribution: liuchanggang commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
3164708-5.patch5.24 KB

@yas,
I updated the patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@liuchanggang

Thank you for the update. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 85901fd on 8.x-2.x authored by liuchanggang 
    Issue #3164708 by liuchanggang, yas: Add a Refresh button in All listing...

  • yas committed af5b433 on 3.x authored by liuchanggang 
    Issue #3164708 by liuchanggang, yas: Add a Refresh button in All listing...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.