Problem/Motivation
A group of radio buttons has a confusingly large vertical margin in between them. They almost look like they don't belong to each other in the same group.
A group of checkboxes OTOH has a much smaller vertical margin.
Checkboxes have a smaller margin due a surrounding div.form-boolean-group
, which is added in core/themes/claro/templates/form/checkboxes.html.twig
.
Radio buttons have a similar markup in core/themes/claro/templates/form/radios.html.twig
.
BUT: The correct template for radio buttons is overwritten by core/themes/claro/templates/classy/form/radios.html.twig
, which does not have the .form-boolean-group
class.
Steps to reproduce
Use the form widget "Checkboxes / Radio buttons" for any entity reference field with a cardinality of 1
Proposed resolution
Delete the incorrect, needlescore/themes/claro/templates/classy/form/radios.html.twig
template.
Comment | File | Size | Author |
---|---|---|---|
#5 | before-patch.png | 217.58 KB | bandanasharma |
#5 | after-patch.png | 280.24 KB | bandanasharma |
#3 | 3164871-3.patch | 1.26 KB | lauriii |
Comments
Comment #2
hudriComment #3
lauriiiTested manually and I couldn't reproduce the problem. For some reason when I test this, the correct template is picked up. However, I can see how the extra template could cause problems if loaded, so here's a patch to remove it.
Comment #4
lauriiiComment #5
bandanasharma CreditAttribution: bandanasharma as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented#3 patch is apply successfully. Adding some manually testing images for more visualization.
Comment #7
catchCommitted d91112e and pushed to 9.1.x. Thanks!