Problem/Motivation

[Drupal\Core\Extension\InfoParserException]
The 'core' or the 'core_version_requirement' key must be present in modules/contrib/xmlsitemap/xmlsitemap_engines/t
ests/modules/xmlsitemap_engines_test/xmlsitemap_engines_test.info.yml

Steps to reproduce

composer require 'drupal/xmlsitemap:^1.0'

Proposed resolution

Drupal.org package script is missing core: '8.x'

Remaining tasks

n/a

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#7 interdiff_4-7.txt350 bytesmunish.kumar
#7 3165131-7.patch1.04 KBmunish.kumar
#5 1209_522_1.5.png42.33 KBAaronwa
#4 3165131-4.patch1.62 KBS_Bhandari
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Aaronwa created an issue. See original summary.

Aaronwa’s picture

Aaronwa CreditAttribution: Aaronwa commented

In /contrib/xmlsitemap/xmlsitemap_engines/tests/modules/xmlsitemap_engines_test/xmlsitemap_engines_test.info.yml'
under the section:

# Information added by Drupal.org packaging script

it is missing core: '8.x'

also it can be added to the section above which is commented out in previous versions.

S_Bhandari’s picture

S_Bhandari CreditAttribution: S_Bhandari as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented

Hi,

I am working on it. Will update as soon as possible.

Thanks.

S_Bhandari’s picture

S_Bhandari CreditAttribution: S_Bhandari as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Active » Needs review
FileSize
3165131-4.patch1.62 KB

Hi,

Added a patch for the same. Please review and let me know for any queries or observations.

Thanks.

Aaronwa’s picture

Aaronwa CreditAttribution: Aaronwa commented
FileSize
1209_522_1.5.png42.33 KB

Working as expected:
working

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid at Lullabot commented
Status: Needs review » Needs work

Hrm, I wonder if we can actually remove the core_version_requirement from testing modules. I remember there being some change around that recently. From https://www.drupal.org/node/3070687:

Note that test modules can omit the core_version_requirement key entirely as of Drupal 8.8.2, so that they will work with any core version they are tested against.

munish.kumar’s picture

munish.kumar CreditAttribution: munish.kumar as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3165131-7.patch1.04 KB
interdiff_4-7.txt350 bytes

Hi @Dave Reid,
#6 changes has been addressed, Please review the patch.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid at Lullabot commented
Version: 8.x-1.0 » 8.x-1.x-dev
Status: Needs review » Needs work

The latest patch does not remove the core_version_requirement key entirely, which is what I was asking of in the previous comment.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid at Lullabot for Principal Financial Group commented
Title: The 'core' or the 'core_version_requirement' key must be present - xmlsitemap_engines_test.info.yml » Update the core_version_requirement in submodules to match main module requirement
Status: Needs work » Reviewed & tested by the community

Oh, this is different from the issue title, this is about the submodule .info.yml files, not the test modules.

  • munish.kumar authored dceed1f on 8.x-1.x 
    Issue #3165131 by munish.kumar, S_Bhandari, Aaronwa, Dave Reid: Update...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid at Lullabot for Principal Financial Group commented
Status: Reviewed & tested by the community » Fixed

Committed #7 to 8.x-1.x. Thanks! Make sure to keep that issue title and description updated when context changes in the future!

  • munish.kumar authored fd0340e on 2.x 
    Issue #3165131 by munish.kumar, S_Bhandari, Aaronwa, Dave Reid: Update...

  • munish.kumar authored dceed1f on 2.x 
    Issue #3165131 by munish.kumar, S_Bhandari, Aaronwa, Dave Reid: Update...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.