Problem/Motivation

Currently the CMIS module don't have method to check Allowable Action

Steps to reproduce

Proposed resolution

Implement method to check AllowableAction

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 Implement_check_permission-3165959-2.patch1.01 KBliber_t
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

liber_t created an issue. See original summary.

liber_t’s picture

liber_t
she/her
Primary language French
Location Lille
CreditAttribution: liber_t at Smile commented
FileSize
Implement_check_permission-3165959-2.patch1.01 KB
liber_t’s picture

liber_t
she/her
Primary language French
Location Lille
CreditAttribution: liber_t at Smile commented
Assigned: liber_t » Unassigned
Status: Active » Needs review
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Status: Needs review » Needs work

Thanks for the patch. Here is my review. I guess you use this new method somewhere else. So it can be updated in another issue.

+++ b/src/CmisConnectionApi.php
@@ -334,4 +334,34 @@ class CmisConnectionApi {
+      return NULL;

This should return FALSE to match the return type PHP Doc.

liber_t’s picture

liber_t
she/her
Primary language French
Location Lille
CreditAttribution: liber_t at Smile commented 
+++ b/src/CmisConnectionApi.php
@@ -334,4 +334,34 @@ class CmisConnectionApi {
+    if (!empty($this->validObjectId($id) || !empty($this->validObjectId($id, 'cmis:document')))) {

Can you remove this line

+++ b/src/CmisConnectionApi.php
@@ -334,4 +334,34 @@ class CmisConnectionApi {
+      return NULL;

change null to FALSE

thanks :)

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Unassigned » Grimreaper

I will also update the PHP Doc.

  • liber_t authored 8db6975 on 8.x-2.x 
    Issue #3165959 by liber_t, Grimreaper: Implement check permission
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Grimreaper » Unassigned
Status: Needs work » Fixed

Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.