Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#5 | 3167439-5.patch | 55.74 KB | jigish.addweb |
Comment | File | Size | Author |
---|---|---|---|
#5 | 3167439-5.patch | 55.74 KB | jigish.addweb |
Comments
Comment #2
jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commentedComment #3
jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commentedComment #4
yasThis is my cosmetic concern about the source code --- Let's align the format of
'key' = $value
to the longest key, which isfield_image_upload_url' => "https://ec2.us-west-${num}.amazonaws.com",
Note that'field_image_upload_url'
should be'field_image_upload_url' => "https://ec2.us-west-${num}.amazonaws.com"
, removing redundant extra one space.Comment #5
jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commentedComment #6
jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented@yas Thank you for your review.
I have done changes as per your comment. Please review the updated patch.
Thanks
Comment #7
yas@jigishaddweb
Thank you for the update. It looks good to me. I'll merge the patch to
8.x-2.x
and3.x
and close this issue asFixed
.Comment #10
yas