Problem/Motivation

An unexpected error happened in SecurityGroupIpPermissionsTest when a Security Group Rule has from_port=0.
So far, this error has not been reproducible. We need to add a test case with from_port=0 so that we see if the same error happens.

https://dispatcher.drupalci.org/job/drupal8_contrib_patches/46851/artifa...

CommentFileSizeAuthor
#2 3167569-2.patch1.28 KBkumikoono
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kumikoono created an issue. See original summary.

kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
FileSize
3167569-2.patch1.28 KB
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented

@kumikoono

Thank you for adding the test case.

@baldwinlouie

What do you think?

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas and @kumikoono,

Thank you for the patch. It looks good to me!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented

@baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-1.x, 8.x-2.x, 3.x and close this issue as Fixed.

  • yas committed 8c27fd1 on 8.x-1.x authored by kumikoono 
    Issue #3167569 by kumikoono, yas, baldwinlouie: Add a test case with...

  • yas committed 50625ef on 8.x-2.x authored by kumikoono 
    Issue #3167569 by kumikoono, yas, baldwinlouie: Add a test case with...

  • yas committed 50c6c16 on 3.x authored by kumikoono 
    Issue #3167569 by kumikoono, yas, baldwinlouie: Add a test case with...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.