Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hello, when using PUTTY and entering the command Drush Rebuilt, the display is as follows
Fatal error: Declaration of Drupal\schema_metatag\SchemaMetatagManager::pivot($c ontent) must be compatible with Drupal\schema_metatag\SchemaMetatagManagerInterf ace::pivot(array $content) in /home/xxxx/public_html/xxxx/modules /schema_metatag/src/SchemaMetatagManager.php on line 12
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | schema_metatag.3168072.9.patch | 1.23 KB | KarenS |
| |||
| #4 | schema_metatag.3168072.4.patch | 852 bytes | Grayle |
| |||
Comments
Comment #2
Jattura CreditAttribution: Jattura commentedComment #3
mightyulysses CreditAttribution: mightyulysses commentedI had the same issue. Until a fix is rolled out, I managed to fix it locally and get my site running by editing the offending function declarations in SchemaMetatagManagerInterface.php in src folder as below. I'm not a coder or a maintainer of this module so I'm not suggesting this is the ideal fix - just wanted to get my site running again until a proper fix is rolled out. 🙂
Line 72
public static function pivot($content);Line 83
public static function countNumericKeys($item);Line 140
public static function arrayTrim($array);Line 156
public static function isObject($array);Line 170
public static function serialize($value);Comment #4
Grayle CreditAttribution: Grayle at Dropsolid commentedHEAD of dev seems to have fixes for these issues, afaict. Dev does still have another problem, though. Calling
$thisin a static method. That I can patch, at least.Comment #5
WebbehDoes the work in #4 solve this issue, for the combination of `dev` branch and the supplied patch?
Marking Needs Review to confirm this, given the Priority on this issue.
Comment #6
Jattura CreditAttribution: Jattura commentedThank you for your efforts. Grayle, However, after applying the patch, the result did not change. This is strange.
Comment #7
Grayle CreditAttribution: Grayle at Dropsolid commentedDid you check out the latest dev release and apply the patch to that? If I do that, I don't have any errors, but I won't be able to properly test that until tomorrow.
Comment #8
Grayle CreditAttribution: Grayle at Dropsolid commentedI tried a full option reinstall of my install profile, which gives this fatal with the latest release. With HEAD of dev + this patch the site successfully installs.
Comment #9
KarenS CreditAttribution: KarenS at Lullabot commentedI would fix this differently.
Comment #10
Grayle CreditAttribution: Grayle at Dropsolid commentedThat's a possible BC break, though.
Comment #11
KarenS CreditAttribution: KarenS at Lullabot commentedI seriously doubt any custom code is using that function, even in this module it's only used in one very specific way. We've already changed numerous other static methods to non-static so if anything was depending on them we've already broken them. This one function was just missed.
Comment #12
KarenS CreditAttribution: KarenS at Lullabot commentedAnd all the static to non-static changes were to get SchemaMetatagManager using dependency injection so the service can be overridden.
Comment #13
KarenS CreditAttribution: KarenS at Lullabot commentedI'm going to agree about not changing the static method. I'll issue a new release after this change is in, then I'm going to move to a new branch where I have a number of changes to make. I found a much cleaner way to organize this code.
Comment #15
KarenS CreditAttribution: KarenS at Lullabot commentedCommitted, thanks!