Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
symfony/phpunit-bridge to 5.1.4 provides an upstream fix for #3162403: Upgrade symfony/phpunit-bridge to 5.1.6 to fix badly formed deprecation error message, so it should be updated once it's out.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#13 | 3168107-13.patch | 8.96 KB | jungle |
#10 | interdiff-5-10.txt | 1.64 KB | jungle |
#10 | 3168107-10.patch | 3.6 KB | jungle |
Comments
Comment #2
mondrakeSymfony 5.1.4 is out
Comment #3
mondrakeTried following instructions from https://www.drupal.org/node/3089540 from a git clone, but not sure I got it right.
Comment #5
jungleChanges to files other than the following 2 files are unnecessary.
Attaching a new patch without interdiff.
Command used:
COMPOSER_ROOT_VERSION=9.1.x-dev composer update symfony/phpunit-bridge -vvv
Comment #6
mondrakeThanks @jungle! Really do not understand what was wrong with #3 - maybe I git cloned and composer installed rather than run a composer project command?
IMO the problem with #5 is that it updates but does not raise the minimum version in composer.json. We need to set ^5.1.4 as minimum to ensure we do not have earlier versions that have the bug from #3162403: Upgrade symfony/phpunit-bridge to 5.1.6 to fix badly formed deprecation error message.
Comment #7
jungleRe #6 I do not think we have to update
^5.1.3
in composer.json to^5.1.4
. We do not want to touch the composer.json file when possible so that we use^
in composer.json .See #3134731: Update coder to 8.3.9 as an example -- while updating coder to 8.3.9, composer.json did not get touched.
Comment #8
mondrake#7 OTOH, #3157434: Deprecate \Drupal\Tests\Traits\ExpectDeprecationTrait in favour of \Symfony\Bridge\PhpUnit\ExpectDeprecationTrait did exactly that - it updated to 5.1.3 and increased the composer.json constraint to ^5.1.3.
Comment #9
andypostThere's more needs update
Comment #10
jungleRe #8, well, this one is what you wanted.
Steps:
COMPOSER_ROOT_VERSION=9.1.x-dev composer update symfony/phpunit-bridge -vvv
Comment #11
mondrakeThanks @jungle. This patch updates symfony/phpunit-bridge to latest version, that is meant to fix an issue on how deprecations are reported by PHPUnit currently.
See an example of current problem in #3166543-15: Deprecate UiHelperTrait::drupalPostForm, keep deprecation silenced, test run report https://www.drupal.org/pift-ci-job/1807297.
Comment #12
mondrakeComment #13
jungleRerolled.
Comment #14
mondrakeThanks a lot!
Comment #16
catchCommitted c5a0d92 and pushed to 9.1.x. Thanks!
Comment #18
xjm