Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
In core/modules/locale/locale.module, $language_list
variable never used.
Comment | File | Size | Author |
---|---|---|---|
#2 | unused_language_list.png | 895.94 KB | shetpooja04 |
#2 | used_language_list.png | 937.4 KB | shetpooja04 |
#2 | 3168261-2.patch | 664 bytes | shetpooja04 |
Comments
Comment #2
shetpooja04 CreditAttribution: shetpooja04 at QED42 commentedCommit ID: 91fc0d3e (screenshot attached: used_language_list)
Link: https://git.drupalcode.org/project/drupal/-/commit/91fc0d3ed91b263940b758588e416f78fd838d26
For Issue: https://www.drupal.org/project/drupal/issues/1905152 the changes were made
File: core/modules/locale/locale.module
$language_list was getting used in above mentioned commit in below code
later in the below commit the line was removed
Commit ID: c34478f5 (screenshot attached : unused_language_list)
Link: https://git.drupalcode.org/project/drupal/-/commit/c34478f5e71a49d7b9af649ed87119367de17a01
For Issue: https://www.drupal.org/project/drupal/issues/2212069 the changes were made
File: core/modules/locale/locale.module
Comment #3
anu.a_95 CreditAttribution: anu.a_95 at Zyxware Technologies commentedApplied Patch #2 successfully
Unused variable $language_list in the locale.module is removed by applying the patch. The Drupal instance worked as normal after applying the patch.
Comment #4
anu.a_95 CreditAttribution: anu.a_95 at Zyxware Technologies commentedComment #6
catchThanks for the research in #2, definitely leftover cruft.
Committed dcc53b3 and pushed to 9.1.x. Thanks!