Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#11 | 3168861-11-8.x-2.x .patch | 72.71 KB | Masami |
| |||
#11 | 3168861-11.patch | 72.7 KB | Masami |
Comments
Comment #2
Masami CreditAttribution: Masami commentedComment #3
Masami CreditAttribution: Masami commentedComment #4
Masami CreditAttribution: Masami commentedComment #5
yas@masami
Thank you for adding the block. I tested Basically it looks good to me.
@masatotakada
What do you think?
Comment #6
Masami CreditAttribution: Masami commentedComment #7
Masami CreditAttribution: Masami commentedComment #8
Masami CreditAttribution: Masami commentedComment #9
yasComment #10
MasatoTakada CreditAttribution: MasatoTakada commented@Masami
Thank you for the patches. It looks good to me except for one question that
is it okay if Cost_type field with string format has any integer number at the line 138 and add it at the line 148??
In my understanding, this field has the type of cost ,like 'on_demand_yearly' and so on, from resource entity.
So, I am worried about zero mismatches it and then it might causes the error.
Comment #11
Masami CreditAttribution: Masami commented@yas
@masatotakada
Thank you for your review. I update the patches, so please review them again.
Comment #12
MasatoTakada CreditAttribution: MasatoTakada commented@masami
Thank you for work. It looks good to me.
Comment #13
yas@masatotakada
Thank you for you review.
@masami
Thank you for the update. I'll merge the patch to
8.x-2.x
and3.x
and close this issue asFixed
.Comment #16
yas