There is currently a fairly major user interaction issue with easylink - if you don't select text to be linked initially the button is still visible and functional, and so you can click on it and then a link in the popup window - however there is no effect at all (no link is inserted) and also no message to the user, giving the appearance that it is broken.

The attached patch improves this behavior by using the node title as the link text if there was no text selected initially. I think this is expected and desired behavior by most users.

This patch also fixes a very similar usability problem when the cursor is inside an existing link there is no effect of easylink and no error message. This is now improved by updating the url for the selected link tag to the link the user clicked on in the popup, which would also be the intended outcome for the user.

The regular expressions have been tweaked to pass the link text into the javascript. I found this approach a bit clunky and tried to replace with a jquery selector based click binding, which should be a lot simpler (3 lines of code) - however there is some interaction with TinyMCE that is preventing the blocking of the default link action that prevents this approach right now.

CommentFileSizeAuthor
insert-link-text.patch4.33 KBOwen Barton
Support from Acquia helps fund testing for Drupal Acquia logo