Problem/Motivation

The code of the hook_page_attachments references the "access cmis browser" permission which no more exist.

Steps to reproduce

Proposed resolution

The library should be added if the user has the permission "access all cmis browsers" or any "access cmis browser $config_id" permission.

Also this hook will be removed in the refactoring for the library to be added when an element with ajax is added.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork cmis-3169424

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Grimreaper created an issue. See original summary.

liber_t’s picture

liber_t
she/her
Primary language French
Location Lille
CreditAttribution: liber_t at Smile commented
Assigned: Unassigned » liber_t

liber_t opened merge request !5

liber_t’s picture

liber_t
she/her
Primary language French
Location Lille
CreditAttribution: liber_t at Smile commented
Assigned: liber_t » Unassigned
Status: Active » Needs review
liber_t’s picture

liber_t
she/her
Primary language French
Location Lille
CreditAttribution: liber_t at Smile commented
Assigned: Unassigned » Grimreaper
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented

I have posted a message on Drupal Slack https://drupal.slack.com/archives/C51GNJG91/p1600077762083900. Waiting a little bit to have a reply.

If no reply I will merge (and I will manually test also before).

The other question I have, and we will see when merging, is how to credit reviewer/tester/other people, as they are not in the commit message.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Status: Needs review » Reviewed & tested by the community

Ok for me.

As a hook had been removed, I think it is a best practice to introduce an empty hook_post_update to clear cache, even if in majority in deployment process a cache clear is involved.

https://www.drupal.org/node/2960601

Like datetime_range_post_update_translatable_separator()

  • 2cc0338 committed on 8.x-2.x 
    Issue #3169424 by liber_t: hook_page_attachments
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Title: hook_page_attachments » Remove hook_page_attachments
Version: 8.x-2.x-dev » 3.0.x-dev

I will cherry-pick on the 3.0.x

  • liber_t authored 0536fef on 3.0.x 
    Issue #3169424 by Grimreaper, liber_t: Remove hook_page_attachments
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Grimreaper » Unassigned
Status: Reviewed & tested by the community » Fixed

Fixing commit message and author.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.