Problem/Motivation

  • Comply with Drupal coding standards
CommentFileSizeAuthor
#12 3169854-12.patch1.94 KBXiaohua Guan
#4 3169854-2-3.x.patch218.46 KByas
#4 3169854-2-8.x-2.x.patch218.46 KByas
#2 3169854-2.patch223.9 KByas
#2 3169854-2-8.x-1.x.patch219.81 KByas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs work » Needs review
FileSize
3169854-2-8.x-1.x.patch219.81 KB
3169854-2.patch223.9 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3169854-2.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs work » Needs review
FileSize
3169854-2-8.x-2.x.patch218.46 KB
3169854-2-3.x.patch218.46 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Related issues: +#3102718: Comply with Drupal coding standard (10)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@all

I'll merge the patch to 8.x-1.x, 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 8666335 on 8.x-1.x 
    Issue #3169854 by yas: Comply with Drupal coding standard (11)

  • yas committed df390ba on 8.x-2.x 
    Issue #3169854 by yas: Comply with Drupal coding standard (11)

  • yas committed 892ac95 on 3.x 
    Issue #3169854 by yas: Comply with Drupal coding standard (11)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Fixed » Needs work
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs work » Needs review
FileSize
3169854-12.patch1.94 KB

@yas

I found some bugs. So I attached a patch. Please check it.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for fixing the bugs. I'll merge the patch to 8.x-1.x, 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 3909344 on 8.x-1.x authored by Xiaohua Guan 
    Issue #3169854 by yas, Xiaohua Guan: Comply with Drupal coding standard...

  • yas committed 0b98d2e on 8.x-2.x authored by Xiaohua Guan 
    Issue #3169854 by yas, Xiaohua Guan: Comply with Drupal coding standard...

  • yas committed d7a2365 on 3.x authored by Xiaohua Guan 
    Issue #3169854 by yas, Xiaohua Guan: Comply with Drupal coding standard...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.