Problem/Motivation

  • Align Terraform Cloud UI terminologies
CommentFileSizeAuthor
#6 3169879-6.patch50.02 KByas
#4 3169879-4.patch50.02 KByas
#2 3169879-2.patch47.8 KByas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Active » Needs review
FileSize
3169879-2.patch47.8 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3169879-2.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs work » Needs review
FileSize
3169879-4.patch50.02 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented

@yas

Thanks for your patch file. It looks good to me except the code below. It seems that "Terraform Cmodule" should be "Terraform Cloud module".
Could you confirm it?

/**
  * @file
- * Terraform module.
+ * Terraform Cmodule.
  *
  * This module handles UI interactions with the cloud system for Terraform.
  */
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
3169879-6.patch50.02 KB

@xiaohua-guan

Thank you for your review :) I fixed the bug, so could you please review the patch again?

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs review » Reviewed & tested by the community

@yas

The patch looks good to me now. So I changed the status to RTBC. Thanks,

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented

@xiaohua-guan

Thank you for your review. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed e08965d on 8.x-2.x 
    Issue #3169879 by yas, Xiaohua Guan: Align Terraform Cloud UI...

  • yas committed 5ca4e2c on 3.x 
    Issue #3169879 by yas, Xiaohua Guan: Align Terraform Cloud UI...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.