Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
To minimize AJAX requests, send the initial dataset with in Drupal.settings.k8s Javascript object when the page is rendered.
Comment | File | Size | Author |
---|---|---|---|
#11 | 3170519-11-fix-coding-standard.patch | 729 bytes | yas |
#2 | 3170519-2.patch | 60.41 KB | baldwinlouie |
Comments
Comment #2
baldwinlouie CreditAttribution: baldwinlouie commentedAttaching patch with this refactoring. The patch refactors the common functions used in the
APIController.php
andK8sNamespaceCostsChartcontroller.php
into aK8sBlockTrait.php
The Blocks can use these common functions to build the initial dataset.
@masami and @MasatoTakada should also review this because the refactoring touches code from the https://www.drupal.org/project/cloud/issues/3168861
Comment #3
baldwinlouie CreditAttribution: baldwinlouie commentedScreenshot of the data sent in the Javascript array.
Comment #4
yas@baldwinlouie
Thank you for the refactoring. I tested the patch and it looks good to me.
@masami
What do you think?
Comment #5
yasComment #6
Masami CreditAttribution: Masami commented@yas
@baldwinlouie
The patch looks great, so I change the status to RTBC.
Comment #7
yas@masami
Thank you for your review. I'll merge the patch to
8.x-2.x
and3.x
and close this issue asFixed
.Comment #10
yasComment #11
yas@baldwinloue @masami
Fixing the coding standard violation.
Comment #12
yasI'll merge the patch to
8.x-2.x
and3.x
and close this issue asFixed
.Comment #15
yas