September 21, 2020 - Meeting Agenda [#3170847]

Meeting Agenda

Introductions
Status
Issue updates and discussion
Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Minutes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every Monday at 2pm GMT (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣ If you’re attending this meeting, please let us know here and leave a comment in the meeting agenda issue so we can give you issue credit on d.o.: #3170847: September 21, 2020 - Meeting Agenda

lauriii	:wave:
mherchel	:sunrise:
hansa11	Hello everyone! :wave:
alexpott	:wave: hullo
proeung	Good morning/afternoon! :wave:
jackh	hello! :wave: took a long break while i settled into a new job, but back to see where i can help out.
shaal	:wave:
kiran.kadam911	Hello everyone!
komal k	Hello Everyone!!
ambuj_gupta	Hello Everyone!
sd9121	Hello

1️⃣ Overall project status update

mtift (he/him)	Our path to beta is currently headed towards Drupal 9.1. [#3111409]Let's use this issue to discuss the overall status of the initiative in broad terms, and we'll save specific issue discussions for later threads.
mherchel	Lots of progress last week!
mherchel	and the good news is that we [currently] have all of our beta criteria met to get into core (as of #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta)
mherchel	That being said, we’re going to do additional grooming, so there might be more beta criteria
mherchel	We have a meeting w @webchick later today to go over that
mherchel	I also put a post in the #accessibility channel for the maintainers to take a look (https://drupal.slack.com/archives/C2ANFUGGG/p1600358418028600)
Gábor Hojtsy (he/him)	@mherchel maybe you can invite me to the meeting with @webchick in case I can make it, so we can speed this up
mherchel	Will do
webchick	@mherchel hey, I'm really sorry, my previous call is running over but i will be there within MERE MINUTES
webchick	@mherchel @proeung @Gábor Hojtsy (he/him) Ok here is my comment. Thoughts?"Reviewed the list of blockers with @mherchel, @proeung, and @Gábor Hojtsy. Made a bunch of recommendations in terms of de-scoping from "must-haves". There was very good work that was done to make sure that the technical debt was adequately captured here, which is important for release management review. However, a lot of things in the list qualify as "yeah we ought to fix that" or "actually that's more of a support request" and so on. We banged through the list to cut it down tremendously so it's mainly focused on the gates (attention to docs, CSS interoperability, accessibility, etc.).I reviewed the demo site and clicked on lots of things, uncovering new delight about every ~7.2 seconds. The logo-to-hamburger menu! The search box! The responsive grids! The attention to detail here is superb, and as much as I tried to break something, I couldn't. Well done, everyone. I would love to see us view "must-haves" through a very critical lens, so we can get this in front of users as soon as possible because this is such a tremendous step forward! :open_mouth: GREAT WORK, Olivero team!!"
Gábor Hojtsy (he/him)	@webchick sounds good
webchick	OK sweet, posted, so that I don't accidentally close that window.Thank you again SO much for your time and effort here!
mherchel	:thumbsup:
proeung	Thank you for taking the time to go over the roadmap with us today. Appreciate your feedback! :raised_hands:

2️⃣ Individual issue discussion

mtift (he/him)	This thread is the place to bring up specific issues that need some extra discussion
mherchel	I’ve been putting in a lot of work on #3095673: Convert codebase to use CSS logical properties for RTL support, which replaces things like margin-left with margin-inline-start for more modern RTL support
mherchel	This is in preparation for #3170864: Add postcss-preset-env
mherchel	I’m pretty close to being wrapped up. I have a gitlab merge request at https://git.drupalcode.org/project/olivero/-/merge_requests/1
mherchel	just so I can track the changes better than a large patch
mherchel	But if anyone wants to do some general QA on it, I’d be grateful (edited)
proeung	@mherchel @lauriii With the proposal to include postcss-preset-env into Core, is now a good time to close out these other postCSS plugins issues?#3093013: Allow PostCSS Plugin “PostCSS RTL” in core for Olivero theme
lauriii	I think we can close those if everyone in your team is onboard with the preset-env approach
mherchel	I am. Still going to be a significant amount of work but its a good path forward.
proeung	Great! I think we're all on board with this direction.
mherchel	The CSS Logical Properties thing was waaaay more work than I expected (29 commits so far and counting)
proeung	@mherchel Interesting. What's your estimation for the refactoring work then?
mherchel	i prob have a legit 10hrs into this so far. Prob 2 hours to go.
mherchel	After this, the biggest thing is the nesting
proeung	Got it! Let me know if there's anything I can help out with.
mherchel	the syntax will be different (& are mandatory) and you can’t do things like [dir="rtl"] &
mherchel	that will prob be at least 6 hours. maybe more.

3️⃣ Where can people help this week?

mtift (he/him)	Share your suggestions here
mherchel	Would love additional QA. Especially around backend elements that appear within the frontend (settings tray, media library modal, layout builder components, etc)
mherchel	also, @lauriii do you have a timeline on the next patch review? Totally cool if it’s not going to happen shortly
mherchel	but I can also submit a new patch at some point (there’s been some changes since the last)
lauriii	I’m working on the postcss-env and few Claro issues right now but I’m planning to start reviewing it tomorrow or Wednesday
lauriii	so you can expect to hear back from me this week still
mherchel	That’s cool. I’m going to try to have an updated patch for you by tomorrow
mherchel	(or sometime early tomorrow) (edited)
alexpott	If there are core blockers like the postcss-env stuff - people should ping me when they need review or rtbc - I’ll prioritise them.
mherchel	Sounds good. No blockers (other than that) atm.
jackh	does "additional QA" = holistic walkthroughs to find issues in those areas? or is there a specific issue in the queue in mind? (edited)

Participants:

lauriii, mherchel, hansa11, alexpott, proeung, jackh, shaal, kiran.kadam911, komal k, ambuj_gupta, sd9121, mtift (he/him), Gábor Hojtsy (he/him), webchick