Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In core/modules/rest/src/Routing/ResourceRoutes.php, $supported_formats
variable never used.
Comment | File | Size | Author |
---|---|---|---|
#2 | 3172846-2.patch | 855 bytes | shetpooja04 |
Comments
Comment #2
shetpooja04 CreditAttribution: shetpooja04 at QED42 commentedCommit ID: 871da5e4
Link: https://git.drupalcode.org/project/drupal/-/commit/871da5e4f723b5b1928956c495a0f148e4cbbaff
File: core/modules/rest/src/Routing/ResourceRoutes.php Line: 93
For Issue: https://www.drupal.org/project/drupal/issues/2308745 the variable is added but not used
Please review
Comment #3
Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commentedHi,
@shetpooja04, I have reviewed your patch and you seems to put all && conditions together.
I am creating updated patch.
Please review this patch.
Let me know for any recommendations.
Thanks.
Comment #4
naresh_bavaskar@Pooja Ganjage (#3 patch)
if condition was added in incorrect way, #2 patch looks to me
Thanks
Comment #5
chaithanya.m CreditAttribution: chaithanya.m at Zyxware Technologies commentedI have reviewed the Patch #2. The variable $supported_formats is never getting used in ResourceRoutes.php It is working fine without this variable.
Comment #8
catchCommitted a5c9c32 and pushed to 9.1.x. Thanks!