Problem/Motivation

Repeated 'will' word in multiple files:

/core/modules/quickedit/js/models/EntityModel.es6.js
/core/modules/views/src/Plugin/views/area/Entity.php

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anmolgoyal74 created an issue. See original summary.

asishsajeev’s picture

Assigned: Unassigned » asishsajeev
asishsajeev’s picture

Assigned: asishsajeev » Unassigned
asishsajeev’s picture

Assigned: Unassigned » asishsajeev
asishsajeev’s picture

Status: Needs review » Reviewed & tested by the community

Patch looks fine.

asishsajeev’s picture

Assigned: asishsajeev » Unassigned
longwave’s picture

Title: Repetive 'will' word in Multiple files. » Repeated 'will' word in multiple files
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/views/src/Plugin/views/area/Entity.php
@@ -132,7 +132,7 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
-      // @todo If the entity does not exist, this will will show the config
+      // @todo If the entity does not exist, this will show the config
       //   target identifier. Decide if this is the correct behavior in

This now needs re-wrapping at 80 characters.

anmolgoyal74’s picture

Status: Needs work » Needs review
FileSize
1.6 KB
Abhijith S’s picture

Applied patch #8 .Works fine

Checking patch core/modules/quickedit/js/models/EntityModel.es6.js...
Checking patch core/modules/views/src/Plugin/views/area/Entity.php...
Applied patch core/modules/quickedit/js/models/EntityModel.es6.js cleanly.
Applied patch core/modules/views/src/Plugin/views/area/Entity.php cleanly.
Abhijith S’s picture

Status: Needs review » Reviewed & tested by the community
larowlan’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Bug Smash Initiative
  1. +++ b/core/modules/quickedit/js/models/EntityModel.es6.js
    @@ -526,7 +526,7 @@
    -        // Trigger the AJAX request, which will will return the
    +        // Trigger the AJAX request, which will return the
             // quickeditEntitySaved AJAX command to which we then react.
    

    this could use a rewrap too.

    in addition we need the compiled version - see https://www.drupal.org/node/2815083

  2. +++ b/core/modules/views/src/Plugin/views/area/Entity.php
    @@ -132,8 +132,8 @@ public function buildOptionsForm(&$form, FormStateInterface $form_state) {
    -      // @todo If the entity does not exist, this will will show the config
    -      //   target identifier. Decide if this is the correct behavior in
    +      // @todo If the entity does not exist, this will show the config target
    +      // identifier. Decide if this is the correct behavior in
    

    we need to retain the hanging indent here (two spaces on subsequent lines in a todo)

anmolgoyal74’s picture

Status: Needs work » Needs review
FileSize
1.67 KB
1.38 KB

Handled both the point in #11.

longwave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

  • catch committed cd8213d on 9.1.x
    Issue #3173440 by anmolgoyal74, larowlan: Repeated 'will' word in...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed cd8213d and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.