README installation, configuration defaults [#3174130]

Comment	File	Size	Author
#3	ckeditor_accessibility_auditor-3174130-3.patch	2.33 KB	Webbeh

Comment #1

30 September 2020 at 15:36

Webbeh created an issue. See original summary.

Log in or register to post comments

Comment #2

Webbeh

he/him/his

Georgia, USA

CreditAttribution: Webbeh at Georgia Institute of Technology commented 30 September 2020 at 15:40

Assigned:

Unassigned

» Webbeh

Log in or register to post comments

Comment #3

Webbeh

he/him/his

Georgia, USA

CreditAttribution: Webbeh at Georgia Institute of Technology commented 30 September 2020 at 15:50

Status:

Active

» Needs review

File	Size
ckeditor_accessibility_auditor-3174130-3.patch	2.33 KB

Log in or register to post comments

Comment #4

Webbeh

he/him/his

Georgia, USA

CreditAttribution: Webbeh at Georgia Institute of Technology commented 30 September 2020 at 15:51

Assigned:

Webbeh

» Unassigned

Log in or register to post comments

Comment #5

mgifford

he/him

English

CreditAttribution: mgifford at OpenConcept Consulting Inc. commented 30 September 2020 at 16:58

Took a quick review and it looks good to me! I haven't walked through and tested it though.

Log in or register to post comments

Comment #6

Not Real CreditAttribution: Not Real as a volunteer commented 1 October 2020 at 08:57

Maybe I am missing something but surely these changes are pointing to the wrong urls

+ * For a full description of the module, visit the project page:
+ https://www.drupal.org/project/admin_menu
+
+ * To submit bug reports and feature suggestions, or track changes:
+ https://www.drupal.org/project/issues/admin_menu

Log in or register to post comments

Comment #7

Webbeh

he/him/his

Georgia, USA

CreditAttribution: Webbeh at Georgia Institute of Technology commented 1 October 2020 at 12:04

Status:

Needs review

» Needs work

#6 is completely correct, I copied that from the README template but never changed it. Good catch!

Marking Needs Work.

Log in or register to post comments

Comment #8

5 October 2020 at 05:29

mandclu committed b080908 on 8.x-1.x authored by Webbeh

Issue #3174130 by Webbeh, Not Real, mandclu: README installation,...

Log in or register to post comments

Comment #9

mandclu CreditAttribution: mandclu at Northern Commerce commented 5 October 2020 at 05:36

Status:

Needs work

» Fixed

Fixed the links, and added one to the community documentation. Also added a maintainers section, since that is part of the suggested README template. Thanks for everyone's work on this.