October 19, 2020 - Meeting Agenda [#3176257]

Meeting Agenda

Introductions
Status and whats next
Plan for moving Olivero issues to core: #3177364: Open Olivero issues should be moved to Drupal core's new "Olivero theme" component
Working on issues going forward
Review process for design changes
Issue updates and discussion
Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Minutes

Hello, welcome to this week’s Front-end theme Olivero meeting!This meeting:• happens every Monday at 2pm GMT (10am ET).• is chat only (no audio or video).• happens in threads so keep an eye on those notifications.• there are about 5-10 minutes between topics for people who are multitasking to follow along.• the agenda is public and anyone can add to it: https://www.drupal.org/project/issues/olivero?component=Meetings• :star: The transcript of this meeting will be exported and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.0️⃣ If you’re attending this meeting, please 1) Let us know here, and 2) comment in the meeting agenda issue above so we can give issue credit on d.o

mherchel	:sunrise:
katannshaw	Hola
hansa11	Hello everyone! :wave:
lauriii	:wave:
vulcanr	Good afternoon/morning everyone
proeung	Happy Monday! :sunny:
thejimbirch	Hello
naresh_bavaskar	Hello
Gábor Hojtsy (he/him)	:wave:
markdorison	Hey friends! :blob_wave:
Ruchi	Hello Everonne!!
shaal	Hello
jackh	:wave:
komal k	Hello
sd9121	Hello

1️⃣ Status and whats next (edited)

mherchel	CONGRATS EVERYONE!!! :partyparrot: :partyparrot: :partyparrot: :partyparrot: :partyparrot:
Gábor Hojtsy (he/him)	WOOOOOOOOT!
mherchel	We’ve completed the second of what I consider to be our largest three milestonesacceptance of designCommit to core as betaMark as stable and make it the default
mherchel	Still a lot of work to do to be marked stable before 9.2, but it’s totally doable! We have until April or May to do so (someone correct me if I’m wrong)
lauriii	You might want to have separate steps for making it stable and making it the default
lauriii	there could be different requirements for two of those milestones
lauriii	getting to stable is usually easier than getting something the default experience
mherchel	Good to know! We need to figure that out
Gábor Hojtsy (he/him)	Week of April 5, 2021 is the alpha for 9.2
mherchel	Do we need to have it be the default by then to have it be the default for the 9.2 release?
Gábor Hojtsy (he/him)	That is a good guideline IMHO, there may be some possibility into beta of 9.2 but not sue. :smile:
mherchel	:thumbsup: so that’s what we’ll shoot for
proeung	@lauriii That's good to know. Also, is the “Post-stable” criteria (see link - #3177296: [META] Make Olivero stable) considered as the roadmap that will get the theme set as default?
lauriii	Some of them could be but presumably not all. We should triage them to see if there are issues that would be requirements for Olivero to be the default theme of Standard
lauriii	Is the plan to deprecate Bartik once Olivero becomes default?
proeung	Makes sense. As for your question, I would think that we would want to deprecate Bartik once Olivero is the default FE theme. Perhaps, we should open up an issue to discuss this further?
lauriii	Yes. That would probably be the first issue that you should mark as a requirement for becoming the default theme :smile:
Gábor Hojtsy (he/him)	Yeah Bartik should be deprecated, I think deprecating Bartik would not be a pre-requisite of making Olivero the default, otherwise we may end up with a default theme that is itself deprecated :wink:
Gábor Hojtsy (he/him)	we should deprecate Bartik as part of making it not the default or shortly after
Gábor Hojtsy (he/him)	for removal in Drupal 10
proeung	That sounds good, thanks for the info!

3️⃣ Plan for moving Olivero issues to core

mherchel	@thejimbirch created #3177364: Open Olivero issues should be moved to Drupal core's new "Olivero theme" component, but I don’t want to just start moving stuff over…
mherchel	I want to look at the issues individually, and then triage them into priorities, etc. I want to make sure the issue is still happening etc
mherchel	and I want to make sure that the title of the issue is updated to indicate that it is for Olivero
proeung	@mherchel and I will be meeting this Wednesday to go through all of the existing issues and triage them accordingly.
mherchel	yep!
thejimbirch	My concern is now there are 2 places where people can post issues.
mherchel	That’s a good point. We’ll need to update the project page for Olivero and docs
thejimbirch	Claro has a message on their page:
thejimbirch	Screen Shot 2020-10-19 at 10.16.43 AM.png
mherchel	I also get notifications for new issues, so I can reply when necessary.
lauriii	Moving issues from the contrib project doesn’t take much time so it would be good if someone could keep an eye on the issue queue and move any issues from there to the core queue
mherchel	That sounds good. I’ll do that
Gábor Hojtsy (he/him)	BTW the replaced by snippet is a message generated by d.o if you fill in the specific “replaced by” entity reference field on the project edit form :slightly_smiling_face:

4️⃣ Working on issues going forward

mherchel	Which leads us into to working on issues going forward!
mherchel	There’s a new “olivero theme” component created for core issues
mherchel	So, we will add new issues in there as appropriate.
lauriii	It might be a good idea to create link with pre-defined filters for Olivero development and pin it on the channel
mherchel	All issues are now core, so there’ll be a lot more process involved, which means that it won’t just be me saying “screw it, i’m committing”
lauriii	That was something that many people requested with Claro when we moved to the core queue
mherchel	will do on creatting that link with pre-defined filters
thejimbirch	It would be great to make this official:#3177318: Identify and add maintainers for Olivero theme to MAINTAINERS.txt and other respective places@mherchel and @proeung have provided excellent leadership during this project and IMHO should be Olivero subsystem maintainers.
lauriii	Are there any designers you would like to appoint as a subsystem maintainer for Olivero?
lauriii	This is sort of related to the topic I proposed for today
proeung	Yes, we do. @Jen Witkowski, please see the link above. :point_up_2:
Gábor Hojtsy (he/him)	The people appointed as maintainers will get special permissions too :wink: eg. you will be able to assign issue credits on core issues and assign issues to other core maintainers
Gábor Hojtsy (he/him)	(normally you cannot do these things in core)
proeung	Nice!
lauriii	Seems like #3177318: Identify and add maintainers for Olivero theme to MAINTAINERS.txt and other respective places was marked as RTBC. Should we move it back to Needs review to give Jen a chance to comment on the issue if she’s interested in becoming Olivero maintainer?
proeung	@Jen Witkowski Would you like to become one of the maintainers specializes in Design for Olivero? If so, can you add a comment in this issue (#3177318: Identify and add maintainers for Olivero theme to MAINTAINERS.txt and other respective places)?
proeung	@lauriii Looks like she's out today and tomorrow. I'll touch base with her on Thursday about this.
lauriii	@proeung would you like to move the issue back to needs review to make sure it doesn’t get committed accidentally?
proeung	yep! Just did. :+1:

5️⃣ Review process for design changes

mherchel	This was added by @lauriii
lauriii	There is already one issue that is changing the designs slightly. What kind of process would you like to apply for those changes?
mherchel	I’m assuming you’re talking about #3177238: Stronger visual affordance for Olivero's textbox form elements (Design only)
mherchel	although there’s also #3156754: Olivero: Center align content (instead of left align)
lauriii	I was thinking of this #3177345: Powered by Drupal block fails WCAG contrast (minimum)
lauriii	It’s a minor change but at least in Claro, we’ve had designers sign-off on all visual changes
mherchel	ahh. My initial thought is that’s somewhat minor. We’ll modify the text colors as appropriate, and make sure it gets a11y team sign off
lauriii	It’s up to you to decide on process that works for you
mherchel	I’d rather remove as much process as possible so we can move faster. We can do it if necessary, and maybe add that step after we become stable?
mherchel	There’s going to be a number of visual changes. Right now, I’m thinking of a number of backend dialogs that creep into the front-end that are not themed very well
mherchel	that includes media library, and the create table dialog from CKEditor (which has some regressions)
lauriii	I don’t think the core process requires you to do anything but it’s important that we keep the designs consistent
mherchel	agree on that. If you or anyone else feels that we need designer approval, I’m all for that. But with a contrast change, I personally don’t feel that’s needed
mherchel	I have been reaching out to @Jen Witkowski in regards to the design changes for the text inputs for example
mherchel	(the a11y team asked for them)
mherchel	Let me know if that’s okay. I’m not going to get upset or anything if we need designer/ux sign off
lauriii	sounds good :thumbsup:

6️⃣ Issue updates and discussion

mherchel	Does anyone have issues they specifically want to discuss?
mherchel	I reached out to our design team regarding #3177238: Stronger visual affordance for Olivero's textbox form elements (Design only)
vulcanr	IIRC Claro had something similar to a Book of Standars, do we have one for Olivero?
vulcanr	I can't remember there was one (been off from this for a while)
mherchel	I don’t believe that we do. We have a figma page, but honestly, I don’t believe that it’s 100% updated.
mherchel	I’d be on board with creating one if that’ help people.
vulcanr	Do we mind having @Jen Witkowski together with another person and do a run-through it ? I just think would be easier for other people to have hands on.. and take something away from Jen's back
vulcanr	colours, standards, fonts and stuff like that
mherchel	I’m okay with that
mherchel	we’d probably want Jared Ponchot in too
vulcanr	I just think that it may help in those "small" issues where contrast is a problem, any person can have a look and pick another color from the standards
vulcanr	^ contrast being just an example
mherchel	agree. We do have a number of variables defined (although those need to be refactored and abstracted out a bit)
katannshaw	I'm up for testing

7️⃣ Where can people help this week?

mherchel

There’s a number of coding standards issues (some easy and some hard). Knocking those out would be excellent. Just be sure to pull down and diff your patch against Drupal 9.1.x HEAD, so we don’t need to re-roll once we move the issues over to the Drupal project

Participants:

mherchel, katannshaw, hansa11, lauriii, vulcanr, proeung, thejimbirch, naresh_bavaskar, Gábor Hojtsy (he/him), markdorison, Ruchi, shaal, jackh, komal k, sd9121