Problem/Motivation

When choosing minutes to include, 0:00 is not generated.

For example:
To create appointment times every 15 minutes beginning at 9am. One would select minutes to include of :00 / :15 / :30 / :45

However this does not display 9:00 / 9:15 / 9:30 /9:45 as expected, because the 9:00 appointment has not been generated.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 smart_date-zero_values-3176352-2.patch1.31 KBmandclu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MrPaulDriver created an issue. See original summary.

mandclu’s picture

mandclu CreditAttribution: mandclu at Northern Commerce commented
Status: Active » Needs review
FileSize
smart_date-zero_values-3176352-2.patch1.31 KB

Thanks for identifying this. Turns out it also impacts the "zero" hour too. Part of the fun of working with a loosely typed language like PHP is being able to tell the difference between zero and null. Fortunately, the recurr library accepts left-padded single digits (e.g. 00, 01, etc) so this turned out to be an easy way to fix this.

Please test this patch and let me know if it resolves the issue for you.

MrPaulDriver’s picture

MrPaulDriver CreditAttribution: MrPaulDriver commented
Status: Needs review » Reviewed & tested by the community

That's a fix

  • mandclu committed 08f6d71 on 3.1.x 
    Issue #3176352 by mandclu, MrPaulDriver: Recurring by minutes: 0:00 does...
mandclu’s picture

mandclu CreditAttribution: mandclu at Northern Commerce commented
Status: Reviewed & tested by the community » Fixed

Great! Merged in.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.