Problem/Motivation

In #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta we did not identify and add subsystem maintainers for Olivero to MAINTAINERS.txt. These maintainers have special roles in the governance structure and additional permissions, like the ability to adjust the Assigned field on behalf of others, assign issue credits in core, etc. See https://www.drupal.org/contribute/core/maintainers#subsystem for what this means.

Proposed resolution

  • Identify subsystem maintainers for Olivero.
  • Provide a patch to MAINTAINERS.txt (committers will do the followup tasks of assigning maintainer permissions, etc).

Remaining tasks

Do it.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#17 3177318-17.patch607 bytespaulocs
#12 3177318-12.patch527 bytesmherchel
#4 3177318.patch457 bytesGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented

I volunteer myself and @proeung (who I just talked to, and should be commenting in this issue shortly)!

proeung’s picture

proeung
she/her
CreditAttribution: proeung as a volunteer commented

I volunteer! :) It's an honor to continue to work on the Olivero theme.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Active » Needs review
FileSize
3177318.patch457 bytes

That would look like this. Is this list complete?

thejimbirch’s picture

thejimbirch CreditAttribution: thejimbirch at Kanopi Studios commented
Status: Needs review » Active

I second mherchel and proeung as Olivero subsystem maintainers. They have both provided excellent leadership throughout the process.

The patch in #4 applies cleanly. Names and usernames are spelled correctly, and both links work.

+1 for RTBC

thejimbirch’s picture

thejimbirch CreditAttribution: thejimbirch at Kanopi Studios commented
Status: Active » Needs review

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

steinmb’s picture

steinmb CreditAttribution: steinmb as a volunteer commented
Status: Needs review » Reviewed & tested by the community
proeung’s picture

proeung
she/her
CreditAttribution: proeung as a volunteer commented
Status: Reviewed & tested by the community » Needs review

Moving this back to "needs review" awaiting a response from @jwitkowski79.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift at Lullabot commented

I support this nomination! Way to go @mherchel and @proeung!

jwitkowski79’s picture

jwitkowski79 CreditAttribution: jwitkowski79 as a volunteer commented

Hi Everyone! I also volunteer myself! It's been amazing work on this project and would love to continue to do so.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
FileSize
3177318-12.patch527 bytes

Yay! It's super valuable to have a designer as an official maintainer. Thanks for volunteering. Updated patch attached!

proeung’s picture

proeung
she/her
CreditAttribution: proeung as a volunteer commented
Status: Needs review » Reviewed & tested by the community

@mherchel Looks good! Thanks for submitting a revised patch for this.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Status: Reviewed & tested by the community » Needs work
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented
Status: Needs work » Needs review

I'd also like to propose Konstantin Shupenko (@kostyashupenko) as a maintainer! He's been instrumental in many of the most difficult issues that we've faced, has been very responsive, and produces quality work!

I've talked with him about the responsibilities listed at https://www.drupal.org/contribute/core/maintainers#subsystem, and he's very enthusiastic (as am I)!

kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko at Skilld commented

Thank you Mike for proposing me. I'd love to be an official maintainer and of course i'll keep an eye on Olivero

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
FileSize
3177318-17.patch607 bytes

New patch to list @kostyashupenko as a maintainer.

proeung’s picture

proeung
she/her
CreditAttribution: proeung as a volunteer commented
Status: Needs review » Reviewed & tested by the community

+1 for including Konstantin Shupenko (@kostyashupenko) as a maintainer. He's a big help with the development of the Olivero theme and he's going to be great on the team!

@paulocs thanks for adding a new patch. Marking this issue as RTBC.

thejimbirch’s picture

thejimbirch CreditAttribution: thejimbirch at Kanopi Studios commented

+1 for RTBC

hansa11’s picture

hansa11 CreditAttribution: hansa11 as a volunteer and at Axelerant commented

+1 for @kostyashupenko.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Needs review

Thanks everyone!

We need everyone who's added in the patch to explicitly comment saying they're read the Subsystem maintainer responsibilities and general maintainer responsibilities and agree to them before we RTBC. :)

kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko at Skilld commented

These articles already triple-checked by me, so i agree :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Needs review » Reviewed & tested by the community

Everyone has +1'd.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Needs review

Ah +1 is not enough... we need an explicit comment from everyone as per #21

#15 accounts for @mherchel
#22 accounts for @kostyashupenko

So we still need a comment from @jwitkowski79 and @proeung - I'm going to ping them in slack.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel commented

I agree to the Subsystem maintainer responsibilities and general maintainer responsibilities.

Putra is on vacation, so it's likely she won't be able to reply until later this week.

jwitkowski79’s picture

jwitkowski79 CreditAttribution: jwitkowski79 as a volunteer commented

Hi! I've read the subsystem maintainer responsibilities and general maintainer responsibilities and agree to both of them. Thanks!

proeung’s picture

proeung
she/her
CreditAttribution: proeung as a volunteer commented
Status: Needs review » Reviewed & tested by the community

I've read the Subsystem maintainer responsibilities and general maintainer responsibilities and agree with them the guidelines outlined.

  • lauriii committed 98fedb2 on 9.2.x 
    Issue #3177318 by mherchel, proeung, kostyashupenko, jwitkowski79:...

  • lauriii committed 6175523 on 9.1.x 
    Issue #3177318 by mherchel, proeung, kostyashupenko, jwitkowski79:...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 98fedb2 and pushed to 9.2.x and 9.1.x. Thank you for stepping up as subsystem maintainers and welcome to the team!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Yay! Thanks everyone, and welcome to the team!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Since Lauri did not mention it, I went to check if all of you got added as issue maintainers to the Drupal core project, and indeed that happened. Now you can assign issues to other maintainers for example.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.