Problem/Motivation

We currently ship Popper.js 2.0.6. However, the latest release of the library is 2.5.4.

Proposed resolution

Update Popper.js to the latest release.

Remaining tasks

-

User interface changes

-

API changes

-

Release notes snippet

Updated Popper.js to 2.5.4

CommentFileSizeAuthor
#6 interdiff.3181059.2-6.txt182.39 KBlongwave
#6 3181059-6.patch217.37 KBlongwave
#2 3181059-2.patch34.98 KBlauriii
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
Status: Active » Needs review
FileSize
3181059-2.patch34.98 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Needs review » Reviewed & tested by the community
  • I applied the patch and tested quickedit... things still popped!
  • I reviewed the diff locally using git diff --color-words and nothing in the js seemed off.
  • I compared the JS to the cdh version linked from github (https://github.com/popperjs/popper-core#2-cdn) and it matched.
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Issue summary: View changes
Issue tags: +9.1.0 release notes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Needs work

Need to update core/assets/vendor/popperjs/popper.min.js.map too

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review
FileSize
3181059-6.patch217.37 KB
interdiff.3181059.2-6.txt182.39 KB

Updated popper.min.js.map.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Reviewed & tested by the community

The popper.min.js.map file in #6 is identical with https://unpkg.com/@popperjs/core@2.5.4/dist/umd/popper.min.js.map

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work

For whatever reason that blew up the test bot.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Reviewed & tested by the community

Triggered a retest, it looks like something happened to the test environment rather than a failure of the code.

  • catch committed d336fce on 9.2.x 
    Issue #3181059 by longwave, lauriii, alexpott, jungle: Update Popper.js...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

  • catch committed 846d132 on 9.1.x 
    Issue #3181059 by longwave, lauriii, alexpott, jungle: Update Popper.js...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 9.2.x-dev » 9.1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.