Problem/Motivation

In #2955842: Deprecate classList library the "core/classList" library was deprecated with the following message:

The "%library_id%" asset library is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use the the native browser implementation instead. See https://www.drupal.org/node/3089511

There is extra "the" in the sentence, that should be removed.
Thanks, Grammarly for pointing that out 😅

This typo exists in 8.9.x and 8.8.x branches because the library was removed starting from 9.0+.

Proposed resolution

Remove it.

Remaining tasks

Review and commit the patch (will publish in a moment).

CommentFileSizeAuthor
#10 3181870-2.patch2.62 KBlongwave
#2 3181870-2.patch2.62 KBMatroskeen

Issue fork drupal-3181870

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Matroskeen created an issue. See original summary.

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Status: Active » Needs review
FileSize
3181870-2.patch2.62 KB

here is the patch

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Matroskeen opened merge request !52

Matroskeen opened merge request !53

Matroskeen closed merge request !53

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Issue tags: +Quick fix
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

The patch needs a re-roll, and/or the merge request needs to be re-opened.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll
FileSize
3181870-2.patch2.62 KB

Reuploading #2, this applies fine to 8.9.x HEAD for me.

$ curl -s https://www.drupal.org/files/issues/2020-11-11/3181870-2.patch | patch -p1
patching file core/core.libraries.yml
patching file core/tests/Drupal/Tests/Listeners/DeprecationListenerTrait.php

(note this doesn't need to go into 9.x at all as the deprecation was removed there already)

Matroskeen’s picture

Matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
CreditAttribution: Matroskeen as a volunteer and at DevBranch, Drupal Ukraine Community commented

Thanks, @longwave.
I also clicked "Rebase" for MR #52. Now it can be merged into 8.9.x https://git.drupalcode.org/project/drupal/-/merge_requests/52

  • catch committed bfac796 on 8.9.x 
    Issue #3181870 by Matroskeen, longwave: Correct typo "the the" in "core/...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Sorry I missed this was 8.9.x only but of course....

Committed bfac796 and pushed to 8.9.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented

Re-saving to mark as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Matroskeen closed merge request !52