Fix CheckoutTest in HEAD

Nice, I fixed something similar in #3171898: Fix broken HEAD a while ago.

I think the remaining fails may be because you need to do the same fix in the CheckoutTest::complete3Ds() helper.

For the iframes, looks like Stripe changed the ids. As changing those is not reliable if they change them again, let's get them from the html with xpath.

+1

+    $cardIframeId = $this->getSession()->getPage()->find('xpath', '//div[@id="card-number-element"]//iframe')->getAttribute('name');

Maybe it's worth having a switchToElementFrame() helper:

protected function switchToElementFrame($elementId) {
  $elementFrameName = $this->getSession()->getPage()->find('xpath', '//div[@id="$elementId"]//iframe')->getAttribute('name'); 
  $this->switchToFrame($elementFrameName);
}

Broken head is critical for core at least.

Nice.

+++ b/tests/src/FunctionalJavascript/CheckoutTest.php
@@ -583,7 +584,8 @@ class CheckoutTest extends CommerceWebDriverTestBase {
       $stripeFrame = '__privateStripeFrame4';

You missed one :(

Looks like this patch ommitted the changes to CheckoutTest::complete3Ds(). Patches are tricky!

Nice. These should be more robust to future changes by Stripe.

I made changes to the tests myself locally.

I initially wanted to remove the following changes:

$cart_link = $this->getSession()->getPage()->findLink('your cart');
-    $cart_link->click();
-    $this->submitForm([], 'Checkout');

Since it didn't appear to be related to the original issue, but I realized there was no point in navigating to the cart page. Tests are already really slow, so if we can gain several seconds here and there, I think we should.

I also removed the call to waitForStripe() since we keep retrying until the iframe is found already.

I have a failure locally that I can't really explain, so uploading my patch to see if the issue occurs on drupal.org.

I think this was due to me removing the sleep(1) in switchToIframe(), tests are now passing for me locally... Probably lost quite some time because of this small change :p.

The changes look good, and the tests are now green which is the main thing!

D8 is passing.
D9 is failing, sadly, because I'd really like this patch committed so that D8 is passing again: it's holding up testing.

Thanks for fixing that, this change looks correct to me and the tests are green now.

Committed! Thanks for your contribution penyaskito!