Problem/Motivation
While using this module as alone, we found that this module is depend on varbase, see below code link:
https://git.drupalcode.org/project/varbase_core/-/blob/8.x-8.x/varbase_c...
Is it possible to move VarbaseEntityDefinitionUpdateManager from varbase to varbase_core?
Steps to reproduce
Given that on the install of Varbase Core module or any of its sub-modules
When they needs to update entity definitions on install or updates
Then the old namespace was not right and the arguments had changed for Drupal 9
And the Support for automatic entity updates has been removed
https://www.drupal.org/node/3034742
Proposed resolution
Remaining tasks
- ✅ File an issue about this project
- ✅ Update to use vardot/entity-definition-update-manager to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ✅ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Release varbase-9.0.2, varbase_core-9.0.8
User interface changes
- None
API changes
- None
Data model changes
- None
Comments
Comment #2
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedThanks, Zhang for reporting
You are right we should avoid calling a none existing class if it was not present.
Please have a look
#3051884: Switch to use [Varbase Entity Definition Update Manager] and remove deprecated \Drupal::entityDefinitionUpdateManager()->applyUpdates()
#3153617: VarbaseEntityDefinitionUpdateManager does not exist.
If you are looking for a quick fix. Please have at look at
https://www.drupal.org/project/varbase_media/issues/3153617#comment-1371...
Options:
What do you suggest on avoiding to use?
Comment #3
zterry95 CreditAttribution: zterry95 at DAVYIN Internet Solutions / 戴文信息科技有限公司 commentedHi Rajab, thanks for quick response.
As there is "Varbase" in the class name, I think "if class exists" is ok.
Also my question is :
Why you put VarbaseEntityDefinitionUpdateManager in varbase, not in varbase_core?
Comment #4
zterry95 CreditAttribution: zterry95 at DAVYIN Internet Solutions / 戴文信息科技有限公司 commentedAnother explain is that:
The varbase profile should depend on varbase_core module.
The varbase_core module should not depend on varbase profile.
Comment #5
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented#3232568: Switch Varbase Entity Definition Update Manager class to extend the vardot/entity-definition-update-manager class library
Comment #7
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #8
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #9
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #10
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #11
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #12
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #13
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #14
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #15
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #16
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #18
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #19
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #20
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented