[backport] EntityQuery accessCheck: field ui cardinality validation should not be access sensitive

Thanks for working on these - the fix is good and the test is great!

I was going to suggest avoiding t() in the assertRaw() call as elsewhere we are trying to remove t(), but as you're following the convention used earlier in the same test I think it's OK to add this here and then clean it all up in one go in the future.

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

This should probably go into 8.9.x too, but it needs a re-roll/rebase there.

Added reroll for Drupal 8.9.x.

This comment has more than 80 chars, please split it into a second line
// Remove the cardinality limit 4 so we can add a node the user doesn't have access to.
Example:

// Remove the cardinality limit 4 so we can add a node the user doesn't have
// access to.

Addressed comment #10.

Thanks, really works well. +1 to it

+++ b/core/modules/field_ui/tests/src/Functional/ManageFieldsFunctionalTest.php
@@ -344,6 +351,47 @@ public function cardinalitySettings() {
+
+    // Assert that you can't set the cardinality to a lower number then the
+    // highest delta of this field (including inaccessible entities) but can
+    // set it to the same.

*than the highest delta (fixed on commit).

Committed c2af52f and pushed to 8.9.x. Thanks!