Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
If you request name/mail then the return method changes from GET to POST and then the error state is not correctly checked.
Steps to reproduce
Try to log in with Apple, then cancel. You get an error: "BadMethodCallException: Required parameter not passed: "code"
Proposed resolution
Use $request->get() instead of $request->query->get(). Note that there's no has() equivalent, so I changed the has() to get. While that is generally not recommended in favor of explicit checks, I think here it is fine.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#2 | social_auth_apple-3202748-2.patch | 1.01 KB | Berdir |
Comments
Comment #2
BerdirComment #3
ayalon CreditAttribution: ayalon at Liip commentedThanks for the patch. I see the issue and fixed it.
Comment #7
ayalon CreditAttribution: ayalon at Liip commentedComment #8
ayalon CreditAttribution: ayalon at Liip commented