Problem/Motivation
Now that we are integrated with the externalauth module, we should make better use of it. Namely, we should use the ExternalAuth::register() method to create new users, and ExternalAuth::userLoginFinalize() to finalize the login process.
Using ExternalAuth::register(), allows us to delete the openid_connect_user_insert() function. The use of ExternalAuth::userLoginFinalize() also allows us to delete the OpenIDConnect::loginUser, which was already only a wrapper for user_login_finalize().
At the same time, we should namespace our use of the provider field in the authmap table, as site builders can create config entities with the same name as existing modules that also use the externalauth module, and this could lead to hard-to-detect bugs.
Proposed resolution
Make the proposed changes. For the provider field, prepend every client name with 'openid_connect.'.
Comments
Comment #3
jcnventura CreditAttribution: jcnventura at 1xINTERNET commented