Problem/Motivation

Now that we are integrated with the externalauth module, we should make better use of it. Namely, we should use the ExternalAuth::register() method to create new users, and ExternalAuth::userLoginFinalize() to finalize the login process.

Using ExternalAuth::register(), allows us to delete the openid_connect_user_insert() function. The use of ExternalAuth::userLoginFinalize() also allows us to delete the OpenIDConnect::loginUser, which was already only a wrapper for user_login_finalize().

At the same time, we should namespace our use of the provider field in the authmap table, as site builders can create config entities with the same name as existing modules that also use the externalauth module, and this could lead to hard-to-detect bugs.

Proposed resolution

Make the proposed changes. For the provider field, prepend every client name with 'openid_connect.'.

Comments

jcnventura created an issue. See original summary.

  • jcnventura authored 92d217f on 2.x
    Issue #3205965 by jcnventura: Improve use of externalauth
    
jcnventura’s picture

Status: Active » Fixed

  • jcnventura authored a68c4ce on 2.x
    Issue #3205965 by jcnventura: Fix failing tests for use of externalauth
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.