t() calls should be avoided in classes, $this->t() instead

CommentFileSizeAuthor
#4 3212954-4_fully_disabled.jpg121.27 KBkleiton_rodrigues
#4 3212954-4_also_enabled.jpg265.79 KBkleiton_rodrigues
#2 3212954-2.patch2.52 KBSamvada_Jain_M
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Samvada_Jain_M created an issue. See original summary.

Samvada_Jain_M’s picture

Samvada_Jain_M CreditAttribution: Samvada_Jain_M at Specbee commented
Assigned: Samvada_Jain_M » Unassigned
Status: Active » Needs review
FileSize
3212954-2.patch2.52 KB
kleiton_rodrigues’s picture

kleiton_rodrigues CreditAttribution: kleiton_rodrigues at CI&T commented
Assigned: Unassigned » kleiton_rodrigues
kleiton_rodrigues’s picture

kleiton_rodrigues CreditAttribution: kleiton_rodrigues at CI&T commented
Assigned: kleiton_rodrigues » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
3212954-4_also_enabled.jpg265.79 KB
3212954-4_fully_disabled.jpg121.27 KB

Applied patch #2 cleanly.
3212954

3212954

Looks good to me, moving to RTBC

kleiton_rodrigues’s picture

kleiton_rodrigues CreditAttribution: kleiton_rodrigues at CI&T commented
Assigned: Unassigned » kleiton_rodrigues
kleiton_rodrigues’s picture

kleiton_rodrigues CreditAttribution: kleiton_rodrigues at CI&T commented
Assigned: kleiton_rodrigues » Unassigned
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented

RTBC++

  • ndf committed 6c1c1e7 on 8.x-1.x 
    #3212954 by Samvada_Jain_M, kleiton_rodrigues, jcnventura: Avoid the use...
ndf’s picture

ndf CreditAttribution: ndf as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Thanks all for the contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.