Problem/Motivation

An error is returned when using Fullcalendar View (double click action) to populate a Smart Date field via it's default widget.

Notice: Undefined index: value in fullcalendar_view_form_node_form_alter() (line 40 of modules/contrib/fullcalendar_view/fullcalendar_view.module).
fullcalendar_view_form_node_form_alter(Array, Object, 'node_event_form') (Line: 539)
Drupal\Core\Extension\ModuleHandler->alter('form', Array, Object, 'node_event_form') (Line: 836)
Drupal\Core\Form\FormBuilder->prepareForm('node_event_form', Array, Object) (Line: 279)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 91)
Drupal\Core\Controller\FormController->getContentResult(Object, Object) (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Via Slack I have spoken with the Smart Date maintainer. He says that Fullcalendar View is making a slightly incorrect assumption about Smart Date's input widget structure and this is the reason for the error. He also believes that a simple fix in Fullcalendar View is possible

Steps to reproduce

- Create a dated content type using Smart Date
- For the node edit form, select Smart Date's inline date range widget
- Enable Fullcalendar View
- Double click the calendar to populate a Smart Date node.
- Error seen

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MrPaulDriver created an issue. See original summary.

MrPaulDriver’s picture

Issue summary: View changes

mandclu made their first commit to this issue’s fork.

mandclu’s picture

Status: Active » Needs review

I made a merge request that should resolve the notice (!16). Apologies for the duplicate merge request, still getting used to the Gitlab merge request flow.

MrPaulDriver’s picture

Status: Needs review » Reviewed & tested by the community

No more errors seen. Marking as RTBC.

KarinG made their first commit to this issue’s fork.

KarinG’s picture

Status: Reviewed & tested by the community » Fixed

Thank you 👍 @mandclu for working through the MR bits (I hear you) and @MrPaulDriver for confirming the fix for this notice.

I've rebased MR 16 and am merging this now.

KarinG’s picture

PS - I also cherry-picked the commit and merged it into 6.x
https://git.drupalcode.org/project/fullcalendar_view/-/merge_requests/21

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.