Problem/Motivation

The Advanced Help project comes with a CSS file (css/help.css) that provide some CSS classes that override the default for common HTML tags when they're rendered in an advanced-help-topic context. An example is this one:

.advanced-help-topic code,
.advanced-help-topic pre {
  background: #f1f1f1;
  border: 1px solid #444;
  display: block;
  margin: 1em;
  padding: .2em;
}

It basically says that <pre> is a synonym for <code>, and both should be rendered as block elements. But <code> is not a block element, it is inline (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/code), so this breaks any help text that uses this CSS element correctly.

Frankly, I don't see why this project need to provide its own CSS. It should instead inherit the CSS provided by the website's theming layer for standard HTML-tag such as <code>, <pre>, <h2>, etc.

If it must have custom CSS (I don't see any need for this), it should be done by custom classes, not altering the styling of standard HTML-tags.

Steps to reproduce

Create a help text that corectly uses <code> for inline code, and observe that it is shown as a block element.

Proposed resolution

Just remove the file css/help.css from the project. This project should not mess with theming.

Comments

gisle created an issue. See original summary.

  • gisle authored 4466b06 on 8.x-1.x
    Issue #3222424 by gisle: Fixed help.css
    
gisle’s picture

Status: Active » Fixed

Fixed in latest 8.x-1.x-dev snapshot.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.