Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Have installed 6.x-1.1 on Drupal 6.4 and everything seems to work fine except node authors don't see the option to get notified when creating a post.
I suppose this is controlled by the option:
"Let registered users select notification on a node basis"
I've set the proper permissions for the node authors. It doesn't work for the super-admin either.
Anyone got similar problem with 6.x-1.1?
Please help, thanks a lot!
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 322482_remove_confusing_text.patch | 2.82 KB | greggles |
Comments
Comment #1
gregglesHere are the steps I took related to this:
1. In my account, set "Receive comment follow-up notification e-mails: " to "No notifications."
2. In the admin/settings/comment_notify unchecked the box for "Let registered users select notification on a node basis"
3. Refreshing a comment form, the selectbox was in fact removed, so that piece was working.
4. I submitted a comment and it was inserted into the database with the "notify" value of 0 which is correct.
5. In my account I changed to "For all comments on this post" and refreshed the comment form.
6. When I submitted the form, the database has the value "1" for Notify which I believe is correct.
7. In my account I changed to "Just for replies to my comment" and refreshed the comment form.
8. When I submitted the form, the database had the value "2" for Notify which I believe is correct.
Can you clarify which piece of those steps either is incorrect or you are not seeing in your installation?
Comment #2
tobiasbhe thinks, thats the node-author can select the notification in the Node-(edit)form. But the option means only, that the User can select the notification per node in the comment-form. if this uncheck, the user dont see the selection in comment (but for anonymous users). And the default notification selection in user account is for every node.
i hope thats is in correct engl. grammar :D
Comment #3
gregglesThat makes sense. Let's change the text on this. I think it should be something like
"Hide the select box and use the user's default setting for registered user comment notification."
I would also be willing to simply remove this feature. It's a confusing setting, probably not used very often, and could easily be done with a form_alter in a custom module on a per-site basis.
Comment #4
mbrship CreditAttribution: mbrship commentedHi greggles,
Razorraser (hi & thanks!) is right in explaining my mis-understanding. I think that option still makes sense as long as a clear caption is there.
I still have a question though. For the forum topic author, will the module notify him once a comment is posted? So that a customer (say) will get notified for a support person's reply on the customer's question?
Thank You!
Comment #5
greggles@mbrship - do you think my proposed caption for the box makes sense (#3)
2nd question: yes, if the user has selected to get node notifications in their user profile then they should get the e-mails.
Comment #6
mbrship CreditAttribution: mbrship commentedI think the original caption is quite ok. I would propose some minor tweak like this:
"Let registered users select notification on a per-node basis"
For the explanation text, I would propose something like this:
"If enabled, registered users will see a select box for notification preference every time they reply to a node. Otherwise, default settings from their user profiles will be used."
By the way, I have some problems in having the node author getting notifications. No matter comment-to-the-node or replies-to-comment, the node author just couldn't get notification. Is that related to this issue: #324992: node author notification was not ported properly ??
Comment #7
greggles@mbrship - probably so, but that is fixed in the latest 6.x-1.x-dev.
Also, I'm really leaning towards removing this feature and providing a tutorial on how to do it via a hook_form_alter.
Comment #8
mbrship CreditAttribution: mbrship commentedgreggles,
I just tested the 6.x-1.x-dev, it solves my problem. thanks!
If you remove that feature, what would be the default behavior? Is that a registered user can always specify his preference on a per-node basis? Or the other way round? I would prefer the former.
Comment #9
gregglesYes, it would be that the registered user sees the field on a per node basis.
I think it is easier to write the form_alter to remove a field than it is to add a field.
Comment #10
mbrship CreditAttribution: mbrship commentedhurray!
Comment #11
gregglesNeeds some testing...but here's a start.
Comment #12
gregglesNow committed to both 6.x and 5.x.
http://drupal.org/cvs?commit=159207
http://drupal.org/cvs?commit=159209