Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
js cookie just released a stable 3.0.0 version https://github.com/js-cookie/js-cookie/releases/tag/v3.0.0
diff: https://github.com/js-cookie/js-cookie/compare/v3.0.0-rc.0...v3.0.0
Comment | File | Size | Author |
---|---|---|---|
#9 | 3225811-9.patch | 7.2 KB | alexpott |
#9 | 6-9-interdiff.txt | 930 bytes | alexpott |
#6 | 3225811-6.patch | 6.54 KB | alexpott |
#6 | 5-6-interdiff.txt | 1.46 KB | alexpott |
#5 | 3225811-5.patch | 6.16 KB | sagarchauhan |
Comments
Comment #2
nod_and here it is, was pretty quick thanks to #3219088: Use package.json to manage third party JS libraries
Comment #3
longwave+1 to the new script, I get exactly the same patch with:
Comment #4
catchThe build successful is deceiving, there's a test failure.
https://dispatcher.drupalci.org/job/drupal_patches/93149/console
Comment #5
sagarchauhan CreditAttribution: sagarchauhan at Srijan | A Material+ Company for Drupal India Association commentedUpdated js-cookie package to 3.0.1 with commands available in #3. The new version of package handles cookie key in a different way for which earlier patch was failing and hence a fix was added in jquery cookie shim (jquery.cookie.shim.es6.js).
As package version is difference, therefore uploading a new patch altogether.
Comment #6
alexpottWe're responsible for the encoding so there's no need to do the decoding We can stop doing the encoding.
Comment #7
catchComment #8
longwaveSo we have a test for this case, that fails on straight upgrade but is fixed by removing a workaround we added in the first place. This looks like the right thing to do so this is nearly RTBC.
Remaining nit: there are two references to 3.0.0-rc.0 in @see tags:
Let's update these to the 3.0.1 readme.
Comment #9
alexpottGreat spot @longwave. Fixed.
Comment #10
longwaveThanks. RTBC :)
Comment #12
catchCommitted e35c56b and pushed to 9.3.x. Thanks!