Problem/Motivation

As identified in #3211049-5: [META] Add all plugins which are available in Drupal core's build of CKEditor 4.3 and confirmed by my manual testing, pasting from Google Docs is not a pleasant experience right now when using the Drupal CKEditor 5 module 😅

The contrast with the pasting experience on a CKEditor 5 demo on https://ckeditor.com/ is … stark.

Steps to reproduce

N/A

Proposed resolution

Add https://github.com/ckeditor/ckeditor5/tree/master/packages/ckeditor5-pas... to our build, and enable it by default.

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork ckeditor5-3227871

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Issue summary: View changes

yash.rode made their first commit to this issue’s fork.

yash.rode’s picture

yash.rode CreditAttribution: yash.rode at Acquia commented
Status: Active » Needs review

yash.rode opened merge request !121

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Needs work

Looks like this causes JS errors, because almost all functional JS tests are failing.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented 
--- Expected
+++ Actual
@@ @@
     2 => 'ckeditor5_essentials'
     3 => 'ckeditor5_heading'
     4 => 'ckeditor5_paragraph'
+    5 => 'ckeditor5_pasteFromOffice'
 )

Great! This makes sense — we should now update the test expectations :) And then this is probably ready!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Hm, it is weird that in the MR only js/build/translations/sr.js is being updated. Why are the other translations not being updated? 🤔

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

I was able to reproduce the js/build/translations/sr.js weirdness locally. I have no idea why this is happening. But it's most definitely a problem with the CKE5 build tooling not being able to do reproducible builds, not a mistake on your end, @yash.rode! 👍😊

Scratch that — I confused myself. I cannot reproduce this… I'd wipe all of my node_modules and then run yarn build if I were you :)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Reviewed & tested by the community

Manually tested — works great! :D

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Reviewed & tested by the community » Fixed

  • Wim Leers committed f91e0e6 on 1.0.x authored by yash.rode 
    Issue #3227871 by yash.rode, Wim Leers: Add ckeditor5-paste-from-office...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.