[D9.3 beta - w/c Nov 8, 2021] Remove remaining uses of t() in tests

This is close. Please see a few comments on the MR.

@core committers please see @TR's request for crediting people in the peer issue #2552067-50: Remove t() from assertion messages in tests.

Thanks

Adding credit per remaining tasks

Crediting @mondrake for reviewing

Getting a second opinion as to whether this needs to wait for a disruptive patch window.

Reviewed the diff and it looks good to me, thanks for using an MR here, the word-diff formatting in gitlab was much easier to review than it would have been with dreditor.

Rerolled

I think we should go for a disruptive window here because the MR doesn't apply to 9.2.x as well. If we could apply it there we could say this isn't going to make security releases harder but it will so let's apply during the 9.3.x beta.

Rerolled

I agree it applies cleanly and fixes a whole lot of problems and should be committed soon.

There are a few cases that the regexp in the summary misses, but I think those are exceptions and should be handled in a clean-up issue. For example, in FileTestBase there are two blocks of code like this:

    if (!isset($message)) {
      $message = t('Expected file permission to be %expected, actually were %actual.', ['%actual' => decoct($actual_mode), '%expected' => decoct($expected_mode)]);
    }
    $this->assertEquals($expected_mode, $actual_mode, $message);

This is missed because the message is a variable rather than an in-line use of t().

But again, I don't want to derail this patch just because of a small number of things like this - what's in this patch is good and appropriate and correct. I would rather add a new child issue in the meta to handle any exceptions like this.

Committed a83a7a7 and pushed to 9.4.x. Thanks!

To maximize the chance of future backports applying cleanly, backported to 9.3.x

Nice work all.

I think the idea was to port it down to 9.2.x to alleviate potential efforts with security patches? Otherwise I do not see much sense to wait for 'disruptive patch windows'

9.2 has had its last bugfix release, any security release would be on top of that tag, so backporting to 9.2.x HEAD won't help security patches apply cleaner unfortunately