It is a bug report, not a feature request.

First of all: The system_mail function includes some taxonomy variables but the action settings form's description does not present these. (%term_name, %term_description, %term_id, %vocabulary_name, %vocabulary_description, %vocabulary_id) These are the hidden variables.

Next: The system_send_email_action function gives the comment's data(in the context) but doesn't use it(just the cid, to load the node). It's a bug. When I make a trigger for new comment, I can't make informative email which contains the comment data. I just make a simple message which contains node data. When anybody comments my blog I read 'You got a new comment'. This is unusable! I want to make a more informative mail that contains the comment body itself. Drupal 6 has this feature but I can't use it because the system module has this bug.

System message is the same.

CommentFileSizeAuthor
#9 323325-3.patch1.05 KBpp
#8 323325-2.patch1.07 KBpp
#6 comment_action_mail.zip958 bytespp
hidden_or_missing_variables_system.module.patch3.86 KBpp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Subscribe

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

BTW this was broken off from http://drupal.org/node/287315#comment-1066369 but I am not entirely sure that it is indeed a different issue. Or at least only part of it is.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Needs work

Right. This patch should not contain the portion of code from the feature request; it should contain only the bug fix. Remove the additional %comment* from the patch.

Artem’s picture

Artem CreditAttribution: Artem commented

Subscribing

bwooster47’s picture

bwooster47 CreditAttribution: bwooster47 commented

My vote is for patching this as is. The current available action is pretty meaningless for sending emails on comments if the email cannot include any info about the subject or body of the comment. No point in having an email action at all for comments in this case.
Oh well....

pp’s picture

pp CreditAttribution: pp commented
FileSize
comment_action_mail.zip958 bytes

Here is a little module which resolve this problem.

mikeybusiness’s picture

mikeybusiness CreditAttribution: mikeybusiness commented

Can we get this patch added to 6.x? Clearly the non working variables need to be fixed.

As far as the fix containing the addition of the comment variables. I feel like they are an implementation of features already part of D6.

pp’s picture

pp CreditAttribution: pp commented
Status: Needs work » Needs review
FileSize
323325-2.patch1.07 KB

Here is a patch which show hidden variables. If you like use comment data use the modul in the #6.

pp’s picture

pp CreditAttribution: pp commented
Title: Hidden or missing variables in the system's send email and messge action » Hidden variables in the system's send email and messge action
Version: 6.x-dev » 7.x-dev
FileSize
323325-3.patch1.05 KB

Ok... i thought. I suggest let's separated the two problem, hidden and missing(comment) variables.

Here is a patch for 7x and #8 for 6x. Please review.

pp

pp’s picture

pp CreditAttribution: pp commented
Status: Needs review » Closed (won't fix)

This issue is ambiguous. Sorry!
I created another issue. #480082: Hidden taxonomy variables in the system's send email and message action
You can find the comment's problem in #287315: Add comment variables to send email action.

core drupal user’s picture

core drupal user CreditAttribution: core drupal user commented
Status: Closed (won't fix) » Needs review

hidden_or_missing_variables_system.module.patch queued for re-testing.

mcurry’s picture

mcurry CreditAttribution: mcurry commented

subscribing

pp’s picture

pp CreditAttribution: pp commented
Status: Needs review » Closed (won't fix)

please read #10

amreesh’s picture

amreesh CreditAttribution: amreesh commented
Status: Closed (won't fix) » Needs review

#8: 323325-2.patch queued for re-testing.