Problem/Motivation

Latest upgrade of advanced_text_formatter causes issues.

Steps to reproduce

Given that the Advanced Text Formatter module was installed
When editing a Manage Display for the body text field as an example
Then Errors will show up for old set of configs

Proposed resolution

There are some patches already on the project related to this issue so just implementing patches will fix the problem

#3231760: addNotice Method does not exist
#3231764: Filter html tags is taken for php filter in field formater since 2.1.0

Switch all custom work with PHP Filter to Limited HTML Tags
AS

The PHP filter has been deprecated. Please use the "Limit allowed HTML tags" filter instead.

Varbase is not using the PHP filter in any of the default display configs

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Fix Advanced Text Formatter with the provided patches
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release varbase-9.0.2, varbase_core-9.0.8, varbase_core-8.8.37

User interface changes

Manage Display for the body text field as an example

Manage Display for the body text field as an example

Warning message - The PHP filter has been deprecated. Please use the "Limit allowed HTML tags" filter instead.

API changes

  • None

Data model changes

  • None
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jedgar1mx created an issue. See original summary.

jedgar1mx’s picture

Rajab Natshah’s picture

Title: Error: Call to undefined method Drupal\Core\Messenger\LegacyMessenger::addNotice() » Fix not existing method notice for the Advanced Text Formatter module and filter html tags in formatter
Project: Varbase Blog (Corporate Blog) » Varbase Core

Thanks, Edgar for filing the issue
Moving this issue to Varbase Core

Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Assigned: Unassigned » Mohammed J. Razem
Issue summary: View changes
Issue tags: +varbase-9.0.2, +varbase-8.8.12, +varbase_core-8.8.37, +varbase_core-9.0.8
Rajab Natshah’s picture

Issue summary: View changes

Rajab Natshah’s picture

Status: Active » Needs review
Rajab Natshah’s picture

Assigned: Mohammed J. Razem » Unassigned
Rajab Natshah’s picture

Status: Needs review » Fixed
Rajab Natshah’s picture

Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Rajab Natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes
Rajab Natshah’s picture

Issue summary: View changes