Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Latest upgrade of advanced_text_formatter causes issues.
Steps to reproduce
Given that the Advanced Text Formatter module was installed
When editing a Manage Display for the body text field as an example
Then Errors will show up for old set of configs
Proposed resolution
There are some patches already on the project related to this issue so just implementing patches will fix the problem
#3231760: addNotice Method does not exist
#3231764: Filter html tags is taken for php filter in field formater since 2.1.0
Switch all custom work with PHP Filter to Limited HTML Tags
AS
The PHP filter has been deprecated. Please use the "Limit allowed HTML tags" filter instead.
Varbase is not using the PHP filter in any of the default display configs
Remaining tasks
- ✅ File an issue about this project
- ✅ Fix Advanced Text Formatter with the provided patches
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Release varbase-9.0.2, varbase_core-9.0.8, varbase_core-8.8.37
User interface changes
Manage Display for the body text field as an example
Warning message - The PHP filter has been deprecated. Please use the "Limit allowed HTML tags" filter instead.
API changes
- None
Data model changes
- None
Comment | File | Size | Author |
---|---|---|---|
#12 | The-PHP-filter-has-been-deprecated--Please-use-the--Limit-allowed-HTML-tags--filter-instead.png | 162 KB | Rajab Natshah |
#12 | Manage-display-atf.png | 117.24 KB | Rajab Natshah |
#2 | fix.issue_.3233388-2.patch | 1.2 KB | jedgar1mx |
Comments
Comment #2
jedgar1mx CreditAttribution: jedgar1mx as a volunteer commentedComment #3
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedThanks, Edgar for filing the issue
Moving this issue to Varbase Core
Comment #4
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #5
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #6
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #9
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #10
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #11
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #12
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #13
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #14
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #15
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #16
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #18
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #19
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #20
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #21
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedComment #22
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commented