Problem/Motivation

It seems FileUploadtest uses rebuildAll way too much, even though it is not needed. I think this is not needed if the testmethod doesnt change settings multiple times, but perhaps even then.

We should remove the rebuildAll calls where possible.

Issue fork drupal-3236255

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bbrala created an issue. See original summary.

bbrala’s picture

bbrala
Location Netherlands
CreditAttribution: bbrala at SWIS commented
Title: Remove rebuildRoutes from FileUploadtest where possible » Remove rebuildAll from FileUploadtest where possible
Issue summary: View changes

mohit.bansal623 opened merge request !1208

mohit.bansal623 made their first commit to this issue’s fork.

mohit.bansal623 opened merge request !1209

mohit.bansal623’s picture

mohit.bansal623 CreditAttribution: mohit.bansal623 as a volunteer and at Axelerant commented
Status: Active » Needs review

Removed unnecessary calls for rebuildAll(). Please review.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Tests are still passing, so this seems valid to me.

larowlan closed merge request !1209

larowlan made their first commit to this issue’s fork.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Nice one

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.