Problem/Motivation

In the constructor of the UpdateProcessor class, the type for the argument $key_value_expirable_factory is KeyValueFactoryInterface whereas there is a KeyValueExpirableFactoryInterface

Proposed resolution

Change the type to KeyValueExpirableFactoryInterface $key_value_expirable_factory

Release notes snippet

Changed the type of $key_value_expirable_factory of UpdateProcessor to KeyValueExpirableFactoryInterface from KeyValueFactoryInterface

CommentFileSizeAuthor
#7 3239471-7.patch1.79 KByogeshmpawar

Issue fork drupal-3239471

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gbaudoin created an issue. See original summary.

gbaudoin’s picture

gbaudoin CreditAttribution: gbaudoin at Swissquote commented
Title: Wrong type of KeyValueFactoryInterface used in the constructor of UpdateProcessore » Wrong type of KeyValueFactoryInterface used in the constructor of UpdateProcessor

gbaudoin opened merge request !1243

gbaudoin opened merge request !1246

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs work

Lots of test failures, it looks like there is a missing use statement.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 for Drupal India Association commented
Assigned: Unassigned » yogeshmpawar

Working on the patch.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 for Drupal India Association commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
FileSize
3239471-7.patch1.79 KB

Added patch which will resolve test failures.

gbaudoin closed merge request !1243

gbaudoin opened merge request !1268

gbaudoin closed merge request !1268

gbaudoin’s picture

gbaudoin CreditAttribution: gbaudoin at Swissquote commented

Thanks @yogeshmpawar, I'm trying to see what is the process to add your patch to my merge request.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

The MR looks correct to me and the tests pass as expected.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Something going on with the MR - the raw diff has a lot of unrelated changes. https://git.drupalcode.org/project/drupal/-/merge_requests/1246.diff

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 for Drupal India Association commented
Status: Needs work » Needs review
Issue tags: -Needs reroll

Hi @catch - I have rebased #1246 this MR with 9.3.x & so it is now ready to review & merge.
Raw diff showing related changes now - https://git.drupalcode.org/project/drupal/-/merge_requests/1246.diff

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

  • catch committed 9b9fcd7 on 9.3.x 
    Issue #3239471 by gbaudoin, yogeshmpawar, longwave: Wrong type of...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 9b9fcd7 and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.