Problem/Motivation

#2976480: Do not send Cache-Tags header if Cache-control: no-cache added a hard dependency to dynamic_page_cache module due to use Drupal\dynamic_page_cache\EventSubscriber\DynamicPageCacheSubscriber;, which doesn't exist unless dynamic_page_cache is enabled.

Steps to reproduce

Disable dynamic_page_cache module and attempt to open any page.

Proposed resolution

Add dynamic_page_cache as a dependency or resolve the parent issue some other way.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork purge-3240230

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tuutti created an issue. See original summary.

mpp’s picture

Status: Active » Reviewed & tested by the community

Thanks, tested on 3.1 with Drupal 9.2

3li’s picture

Same issue resolved with this PR, Drupal 9.2

BryanDeNijs’s picture

Thanks for the patch! Works like a charm.

japerry’s picture

Ahh yes I had that enabled as well, disabling could reproduce the error and this patch fixes it. +1

japerry’s picture

nielsvm’s picture

Status: Reviewed & tested by the community » Fixed

Thanks everyone for saving the day here, emergency release 3.2 is soon to be released.

  • nielsvm committed da4aaa7 on 8.x-3.x
    Issue #3240230 by tuutti, japerry, mpp, Eli.Stone, BryanDeNijs: 3.1...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vikas shishodia’s picture

Hi Team,
After this code change We are facing https://www.drupal.org/project/drupal/issues/3265147 issue

Can anyone please help into this.

jakegibs617’s picture

I also am facing the same issue as seen in #11. Is this being worked on already in the purge issues?

I see X-Drupal-Cache: HIT is working but X-Drupal-Dynamic-Cache: UNCACHEABLE always is Uncachable.

I am using:
"drupal/purge": "^3.2",
"drupal/varnish_purge": "^2.1",

and varnish version 6.6.1-3