Problem/Motivation
#2976480: Do not send Cache-Tags header if Cache-control: no-cache added a hard dependency to dynamic_page_cache module due to use Drupal\dynamic_page_cache\EventSubscriber\DynamicPageCacheSubscriber;
, which doesn't exist unless dynamic_page_cache is enabled.
Steps to reproduce
Disable dynamic_page_cache module and attempt to open any page.
Proposed resolution
Add dynamic_page_cache as a dependency or resolve the parent issue some other way.
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork purge-3240230
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3240230-3.1-release-added changes, plain diff MR !4
Comments
Comment #3
mpp CreditAttribution: mpp at AmeXio for District09 commentedThanks, tested on 3.1 with Drupal 9.2
Comment #4
3liSame issue resolved with this PR, Drupal 9.2
Comment #5
BryanDeNijsThanks for the patch! Works like a charm.
Comment #6
japerryAhh yes I had that enabled as well, disabling could reproduce the error and this patch fixes it. +1
Comment #7
japerryAdded your patch here: https://www.drupal.org/project/purge/issues/3240337
Comment #8
nielsvm CreditAttribution: nielsvm commentedThanks everyone for saving the day here, emergency release 3.2 is soon to be released.
Comment #11
vikas shishodia CreditAttribution: vikas shishodia commentedHi Team,
After this code change We are facing https://www.drupal.org/project/drupal/issues/3265147 issue
Can anyone please help into this.
Comment #12
jakegibs617 CreditAttribution: jakegibs617 as a volunteer and commentedI also am facing the same issue as seen in #11. Is this being worked on already in the purge issues?
I see X-Drupal-Cache: HIT is working but X-Drupal-Dynamic-Cache: UNCACHEABLE always is Uncachable.
I am using:
"drupal/purge": "^3.2",
"drupal/varnish_purge": "^2.1",
and varnish version 6.6.1-3