Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When adding multi-product condition you select the products, fill in the rest of the form and submit.
Then on the Discount page eg admin/store/discounts/1
There is no entry in the ITEM column of the table.
When you go back to edit the condition there are no products selected.
The condition doesn't seem to be applied to the cart.
The products do however seem to be stored in the database.
Hope that helps,
m
Comment | File | Size | Author |
---|---|---|---|
#4 | uc_discounts_multiproduct.patch | 5.11 KB | mikgreen |
#3 | uc_discount_multi_product.patch | 486 bytes | mikgreen |
Comments
Comment #1
psynaptic CreditAttribution: psynaptic commentedI couldn't get Multi Product to work in my local test environment. This module really needs a full audit. Will post back here when we have a fix.
Comment #2
sphism CreditAttribution: sphism commentedpsynaptic: Thanks for all your efforts on this, we really appreciate it.
I really like the look of the discount modules, great concept, but i think it will take a bit of work to get it all up to scratch.
Good luck,
m
Comment #3
mikgreen CreditAttribution: mikgreen commentedHere is a patch that got this module working for me.
When you edit a condition - the "Multiple Product/Types" field is actually getting saved to DB.
It's only not being shown when you view the conditon (which I believe is a bug) and when you edit the condition you need to select all the products again (which is somehow connected to multipart form limitations).
Overall uc_discounts is good package, but with some bugs and absent documentation.
Comment #4
mikgreen CreditAttribution: mikgreen commentedHere is more complete patch that fixes multi product discounts.
Comment #5
torgosPizzaThis patch worked for me.
Comment #6
psynaptic CreditAttribution: psynaptic commentedAwesome. Thanks for testing torgosPizza!
Comment #7
sven33 CreditAttribution: sven33 commentedI tried this patch on a drupal 6 test system as I was experiencing some similar issues with multi-products condition.
It looks like the patch partially worked, although it does get a hunk #1 failure when patching uc_discounts.module - see check trace below
If actually apply the patch rather than just checking it the reject file looks like this
The function uc_discounts_condition_form is not found in my v6 uc_discounts.module which is where the hunk fails. I'm using uc_discounts-6.x-1.x-dev
Interestingly the patches for discounts/uc_discounts_multi_product.module all succeed with no offset adjustments so those patches might be appropriate for v6 as well. Unfortunately these changes do not seem to help overcome the issue #329674: can't get a multi-product discount to be applied in any form which I am also experiencing.
Comment #8
mikgreen CreditAttribution: mikgreen commentedYes, it seems this particular patch helps fix discount editing problem also for D6 version.
Comment #9
Scott M. Sanders CreditAttribution: Scott M. Sanders commentedIf you select a lot of products (and if they all show up -- see http://drupal.org/node/635710), the item field lists the entire array in one unbreaking string, which looks pretty bad and I think should be truncated (...) at least for display purposes.