Problem/Motivation

Update JavaScript dependencies loaded using Yarn prior to 9.3.0:

Minor

Package Current Wanted Latest URL
@babel/core 7.14.2 7.15.8 7.15.8 https://babel.dev/docs/en/next/babel-core
@babel/preset-env 7.14.2 7.15.8 7.15.8 https://babel.dev/docs/en/next/babel-preset-env
@babel/register 7.13.16 7.15.3 7.15.3 https://babel.dev/docs/en/next/babel-register
@popperjs/core 2.9.2 2.10.2 2.10.2 https://github.com/popperjs/popper-core#readme
eslint-plugin-import 2.23.2 2.25.2 2.25.2 https://github.com/import-js/eslint-plugin-import
eslint-plugin-react 7.23.2 7.26.1 7.26.1 https://github.com/yannickcr/eslint-plugin-react
glob 7.1.7 7.2.0 7.2.0 https://github.com/isaacs/node-glob#readme
nightwatch 1.6.4 1.7.11 1.7.11 http://nightwatchjs.org
prettier 2.3.0 2.4.1 2.4.1 https://prettier.io
sortablejs 1.13.0 1.14.0 1.14.0 https://github.com/SortableJS/Sortable#readme
terser 5.7.0 5.9.0 5.9.0 https://terser.org

Patch

Package Current Wanted Latest URL
chalk 4.1.1 4.1.2 4.1.2 https://github.com/chalk/chalk#readme
chokidar 3.5.1 3.5.2 3.5.2 https://github.com/paulmillr/chokidar
eslint-plugin-yml 0.10.0 0.10.1 0.10.1 https://ota-meshi.github.io/eslint-plugin-yml/
js-cookie 3.0.0-rc.0 3.0.0-rc.0 3.0.1 https://github.com/js-cookie/js-cookie#readme
tabbable 5.2.0 5.2.1 5.2.1 https://github.com/focus-trap/tabbable#readme

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3246141

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lauriii created an issue. See original summary.

lauriii opened merge request !1346

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Active » Reviewed & tested by the community

This looks good. I've run the same update locally and got the same changes. I've scan reviewed the minified JS changes and there's things like:

function(t,i){switch(this._super(t,i),t){case"handles":this._removeHandles(),this._setupHandles()}}

becomes 

function(t,i){if(this._super(t,i),"handles"===t)this._removeHandles(),this._setupHandles()}
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work

Build's failing on an Olivero test:

11:28:56 TEST FAILURE: 1 error during execution; 0 assertions failed, 1279 passed (3m 50s)
11:28:56 
11:28:56  ✖ Olivero/oliveroDesktopMenuTest
11:28:56  – Verify Olivero desktop menu hover functionality (244ms)
11:28:56 
11:28:56   Error: Error while running "moveToElement" command: "Error: moveToElement method expects 4 (or 5 if using implicit "css selector" strategy) arguments - 3 given.

longwave made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Needs review

Pushed a fix.

I couldn't get the "link text" locator to work any more, so I used the ID instead as in the click test. I also added assertions that the element wasn't visible before moving.

The docs do say that "if an element is provided but no offset, the mouse will be moved to the center of the element", but this appears to no longer be true in the latest Nightwatch: https://nightwatchjs.org/api/moveToElement.html

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Actually, I guess "link text" isn't supposed to work on the button element, because it's a button and not a link.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Needs review » Reviewed & tested by the community

The test fixes look good to me.

init90’s picture

init90
Location Ukraine
CreditAttribution: init90 at ZANZARRA Drupal Agency, Drupal Ukraine Community commented
Related issues: +#3225811: Update to js-cookie 3.0.1

  • catch committed b78a933 on 9.3.x 
    Issue #3246141 by lauriii, longwave: Update JavaScript dependencies...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +9.3.0 release notes

Committed b78a933 and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.