Problem/Motivation

Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.

Proposed resolution

Update ContentTranslationUITestBase and all classes that extend this class to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.

The tests that extend ContentTranslationUITestBase are:

  1. MenuLinkContentTranslationUITest in menu_link_content.module
  2. BlockContentTranslationUITest in block_content.module
  3. CommentTranslationUITest in comment.module

    4. (already uses stark)

  4. ContentTestTranslationUITest in content_translation.module
  5. MediaTranslationUITest in media.module
  6. NodeTranslationUITest in node.module

    7. (already uses stark)

  7. ShortcutTranslationUITest in shortcut.module
  8. TermTranslationUITest in taxonomy.module
  9. UserTranslationUITest in user.module

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3247901-3.patch5.29 KBdanflanagan8
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
CreditAttribution: danflanagan8 at Horizontal commented
Parent issue: #3247694: User tests should not rely on Classy » #3083275: [meta] Update tests that rely on Classy to not rely on it anymore
danflanagan8’s picture

danflanagan8
Primary language English
Location St. Louis, US
CreditAttribution: danflanagan8 at Horizontal commented
Assigned: danflanagan8 » Unassigned
Status: Active » Needs review
FileSize
3247901-3.patch5.29 KB

This turned out to be really easy. There was only a single change required in the base class and then all the other classes passed with stark.

I also did a check that there weren't any negative assertions that would possibly get messed up moving from classy to stark. That's something that will be harder to catch in issues like this I think.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

This looks OK to me.

  • catch committed 84ef68c on 9.4.x 
    Issue #3247901 by danflanagan8, longwave: ContentTranslationUITestBase...

  • catch committed c0dca8d on 9.3.x 
    Issue #3247901 by danflanagan8, longwave: ContentTranslationUITestBase...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.4.x and cherry-picked to 9.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.