Follow-Up of #3220360: COOKiES Integration & enhanced Cookie Opt-In

Problem/Motivation

Add issue component "cookies_etracker"

- [x] @sunlix: Could you please add a component "cookies_etracker" in the project edit settings to make it selectable for issues?
- [x] Uncomment tests in cookies_etracker once the two upstream issues are fixed: #3250126: Submodule dependencies are ignored if composer.json present in parent module (only in issue fork test runs!) & #3249874: Missing "store_auth_user_consent" variable in cookies.config.schema.yml

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork etracker-3249459

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anybody created an issue. See original summary.

Anybody’s picture

sunlix’s picture

- [x] @sunlix: Could you please add a component "cookies_etracker" in the project edit settings to make it selectable for issues?

Anybody’s picture

Title: Cookies integration optimizations » [PP-1] Cookies integration optimizations
Status: Active » Postponed

Thank you @sunlix :)

I'll then postpone this issue on #3249445: Any API to check cookie service consent server-side? for now.

Anybody’s picture

Component: Code » cookies_etracker
Anybody’s picture

Issue summary: View changes
Anybody’s picture

Issue summary: View changes
Anybody’s picture

Issue summary: View changes

Updated the issue summary and removed an unsolvable idea.

Anybody’s picture

Title: [PP-1] Cookies integration optimizations » Cookies integration optimizations
Status: Postponed » Needs review

@Grevil: It seems the tests issues are resolved here? I don't see any commented tests anymore. Can we close this fixed?

Grevil’s picture

Status: Needs review » Fixed

I don't remember any more, but since all the tests are green and uncommented, I guess we can close this.

Anybody’s picture

Title: Cookies integration optimizations » [PP-1] Fix failing tests in submodule due to infrastructure issue with composer
Status: Fixed » Postponed

Sadly, this seems to happen again. I just saw tests were still failing due to this reason in #3220360: COOKiES Integration & enhanced Cookie Opt-In and now also in #3301609: JS has hard dependency of cookies/cookiesjsr causes double load of cookiesjsr-preloader. In both cases the tests themselves are fine, but due to the reasons given in the core issue, the cookies module is not installed as dependency for the submodules.

No idea how to proceed here without feedback from the infrastructure / core maintainers in the upstream issue.

Anybody’s picture

This is REALLY strange! As I just saw, the tests are green on the project page, but seem to be failing in the issue forks?!

I'll create a fresh issue fork here and make an unrelated change for reproduction... If this is true, we should add this information to the upstream issue.

Anybody’s picture

Status: Postponed » Needs review
Anybody’s picture

Status: Needs review » Postponed
FileSize
458 bytes

Indeed! While the test at https://www.drupal.org/node/475370/qa pass and are green, they fail in the frehs issue fork here!

I'll add this information and example to the upstream issue. But before, I'll try the same with a patch :)

Anybody’s picture

Hahahahaha.... going crazy! Exactly the SAME works as patch!

So this is definitely an issue with isssue forks and their tests in combination with composer and submodule test dependencies... WHAO!

So let's postpone this again on the upstream issue and we should all remember this dangerous false negative!

Anybody’s picture

Title: [PP-1] Fix failing tests in submodule due to infrastructure issue with composer » [PP-1] Failing issue fork tests in submodule due to infrastructure issue with composer
Anybody’s picture

Status: Postponed » Active

The solution was just posted upstream. Use require-dev for these kind of dependencies and it will work :)

Anybody’s picture

Issue summary: View changes
Status: Active » Needs review

Tests are already uncommented. Let's see if this now also works in issue forks!

Anybody’s picture

Status: Needs review » Reviewed & tested by the community

Yay it works! So let's finally fix this, so that tests don't fail (unrelated) in issue forks anymore!
#3249459: Failing issue fork tests in submodule due to infrastructure issue with composer

Grevil’s picture

Status: Reviewed & tested by the community » Fixed

LGTM!

  • Anybody committed caf8ade on 8.x-3.x
    Issue #3249459 by Anybody: [PP-1] Failing issue fork tests in submodule...
Anybody’s picture

Title: [PP-1] Failing issue fork tests in submodule due to infrastructure issue with composer » Failing issue fork tests in submodule due to infrastructure issue with composer

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.