Follow-Up of #3220360: COOKiES Integration & enhanced Cookie Opt-In
Problem/Motivation
Add issue component "cookies_etracker"
- [x] @sunlix: Could you please add a component "cookies_etracker" in the project edit settings to make it selectable for issues?
- [x] Uncomment tests in cookies_etracker once the two upstream issues are fixed: #3250126: Submodule dependencies are ignored if composer.json present in parent module (only in issue fork test runs!) & #3249874: Missing "store_auth_user_consent" variable in cookies.config.schema.yml
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#16 | 3249459-test-tests.patch | 458 bytes | Anybody |
|
Issue fork etracker-3249459
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
AnybodyComment #3
sunlix- [x] @sunlix: Could you please add a component "cookies_etracker" in the project edit settings to make it selectable for issues?
Comment #4
AnybodyThank you @sunlix :)
I'll then postpone this issue on #3249445: Any API to check cookie service consent server-side? for now.
Comment #5
AnybodyComment #6
AnybodyComment #7
AnybodyComment #8
AnybodyComment #9
AnybodyUpdated the issue summary and removed an unsolvable idea.
Comment #10
Anybody@Grevil: It seems the tests issues are resolved here? I don't see any commented tests anymore. Can we close this fixed?
Comment #11
Grevil CreditAttribution: Grevil at DROWL.de commentedI don't remember any more, but since all the tests are green and uncommented, I guess we can close this.
Comment #12
AnybodySadly, this seems to happen again. I just saw tests were still failing due to this reason in #3220360: COOKiES Integration & enhanced Cookie Opt-In and now also in #3301609: JS has hard dependency of cookies/cookiesjsr causes double load of cookiesjsr-preloader. In both cases the tests themselves are fine, but due to the reasons given in the core issue, the cookies module is not installed as dependency for the submodules.
No idea how to proceed here without feedback from the infrastructure / core maintainers in the upstream issue.
Comment #13
AnybodyThis is REALLY strange! As I just saw, the tests are green on the project page, but seem to be failing in the issue forks?!
I'll create a fresh issue fork here and make an unrelated change for reproduction... If this is true, we should add this information to the upstream issue.
Comment #15
AnybodyComment #16
AnybodyIndeed! While the test at https://www.drupal.org/node/475370/qa pass and are green, they fail in the frehs issue fork here!
I'll add this information and example to the upstream issue. But before, I'll try the same with a patch :)
Comment #17
AnybodyHahahahaha.... going crazy! Exactly the SAME works as patch!
So this is definitely an issue with isssue forks and their tests in combination with composer and submodule test dependencies... WHAO!
So let's postpone this again on the upstream issue and we should all remember this dangerous false negative!
Comment #18
AnybodyComment #19
AnybodyThe solution was just posted upstream. Use require-dev for these kind of dependencies and it will work :)
Comment #20
AnybodyTests are already uncommented. Let's see if this now also works in issue forks!
Comment #21
AnybodyYay it works! So let's finally fix this, so that tests don't fail (unrelated) in issue forks anymore!
#3249459: Failing issue fork tests in submodule due to infrastructure issue with composer
Comment #22
Grevil CreditAttribution: Grevil at DROWL.de commentedLGTM!
Comment #24
Anybody