Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
\Drupal\package_manager\Stage::getStageDirectory was added in #3250696: Each stage should have its own staging directory, to avoid filesystem and locking conflicts
Maybe we should see if anyone actually needs to be public. You can already get the staged packages via \Drupal\package_manager\Stage::getStageComposer. I think the problem with not making it public is that people will realize they can do $this->pathLocator->getStageDirectory() . "/$stage_id" to get the directory then if we wanted to somehow change this like using "stage_" . $stage_id" we couldn't change the pattern without breaking code.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork automatic_updates-3251972
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
tedbowComment #3
tedbowSeeing a need for this to public in #3252126: Do not apply updates during cron if there are DB updates in the staging area. we will to look for new update functions without actually loading the php files. So we need to be able to load the .install files and .post_update.php files. So we need to know the location of the staging directory.
Comment #5
tedbowComment #6
phenaproximaAll I have is non-blocking nitpicks. Fix them if you want, but RTBC if you wanna just go ahead and commit anyway.
Comment #8
phenaproxima