Upgrade Chromedriver

That works. Need to be backported to 9.4.x because I need a higher version of chrome to test #3248469: Research if the CKE off-canvas CSS reset could be optimized (complex selector inside :has())

Patch failed to apply. I'm also wondering if this will actually resolve the problems from #3248469: Research if the CKE off-canvas CSS reset could be optimized with DrupalCI because DrupalCI is using it's own approach for loading chromedriver.

It needs to update docker images, so needs ping @mixologic at infra slack

Is getting @mixologic involved the only thing that needs to happen here? This might be blocking progress on #3257274: Implement color changing theme settings for Olivero.

From the #olivero slack:
@andy-blum: mherchel I don’t know why the nightwatch tests are failing for the color changing issue. Can you take a look?
@mherchel: Works for me locally too. When I google the error, it comes up to an old NightwatchJS issue that was closed for inactivity. maybe updating chromdriver will fix this (there’s an issue), or we might just need to refactor our way around it 😞

This is on the must-have list for Drupal 10. While it could be major (because technically we can update our dev dependencies in minor releases), the fact that it's also blocking other work makes it borderline-critcal.

would be great to define policy for updates as chrome has 4-weeks release cycle https://chromium.googlesource.com/chromium/src/+/master/docs/process/rel...

There's existing issue for infra team #3208793: Update Chrome container to use newer version

10.0.x patch is passing, but the 9.4.x is failing. Here is another patch against 9.4.x. This was generated by running yarn upgrade chromedriver --latest<code>

Changes look good and all tests are green. Moving to RTBC

@andypost this is the chromedriver used by nightwatch locally - it is not the same chromedriver as used by DrupalCI. And yes this definitely confusing.

Committed 5057625 and pushed to 10.0.x. Thanks!

I think the 9.4.x patch needs work. If I apply that on 9.4.x and run yarn install the lock file changes and that is unexpected.

#12 is correct for yarn.lock but is missing the change to package.json.

Adding the FLDC2022 tag so we can track issues we worked on during Florida DrupalCamp contrib day, thanks!

Committed 59dacfe and pushed to 9.4.x. Thanks!

I'm guessing we won't backport this to Drupal 9.3?

It's not the biggest deal, but it means that the #3259769: Add tests for CKEditor 5 off-canvas CSS reset CKEditor 5 test coverage will not be able to run in Drupal 9.3.